chrome/browser/task_manager.cc - Issue 99161: Handle all accelerators in focus manager when focused view doesn't want to ta...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/task_manager.cc

Issue 99161: Handle all accelerators in focus manager when focused view doesn't want to ta... (Closed) Base URL: http://src.chromium.org/svn/trunk/src/

Patch Set: '' Created 11 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/task_manager.cc

===================================================================

--- chrome/browser/task_manager.cc (revision 14861)

+++ chrome/browser/task_manager.cc (working copy)

@@ -784,9 +784,7 @@

SetContextMenuController(this);

kill_button_.reset(new views::NativeButton(

this, l10n_util::GetString(IDS_TASK_MANAGER_KILL)));

- // TODO(hamaji): Use accelerator once the bug in FocusManager fixed.

- // http://crbug.com/11073

- // kill_button_->AddAccelerator(views::Accelerator('E', false, false, false));

+ kill_button_->AddAccelerator(views::Accelerator('E', false, false, false));

kill_button_->SetAccessibleKeyboardShortcut(L"E");

about_memory_link_.reset(new views::Link(

l10n_util::GetString(IDS_TASK_MANAGER_ABOUT_MEMORY_LINK)));

@@ -920,8 +918,6 @@

void TaskManagerContents::OnKeyDown(unsigned short virtual_keycode) {

if (virtual_keycode == VK_RETURN)

task_manager_->ActivateFocusedTab();

- else if (virtual_keycode == 'E')

- task_manager_->KillSelectedProcesses();

}

// views::LinkController implementation

« no previous file with comments | « chrome/browser/tab_contents/tab_contents_view_win.cc ('k') | chrome/browser/views/location_bar_view.cc » ('j') | no next file with comments »