Removes an unused boolean passed to MoveToFront.

Two changes:

. Removes MoveToFront on Widget.
. CHanges AsWindow to GetWindow.

BUG=none
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=14868

[Ben Goodger (Google), 2009-04-28 17:57:10]

Does this really activate it? why not just call Activate() then on Window?

I thought tab dragging explicitly relied on this not activating.

[sky, 2009-04-28 18:04:59]

On 2009/04/28 17:57:10, Ben Goodger wrote:
> Does this really activate it?

Yep. You can see from this patch that DraggedTabController is the only place
that calls MoveToFront and it always passes in true.

> why not just call Activate() then on Window?

This has a reference to the Widget, not the window. I suppose I could get the
root and activate it and remove this method entirely. What do you think?

> I thought tab dragging explicitly relied on this not activating.

Not sure. I certainly see the halo change on vista when dragging to a different
tab strip.

[sky, 2009-04-28 22:38:34]

New snapshot uploaded

[Ben Goodger (Google), 2009-04-28 23:03:56]

http://codereview.chromium.org/99133/diff/14/1018
File chrome/views/widget/widget_win.cc (right):

http://codereview.chromium.org/99133/diff/14/1018#newcode35
Line 35: HWND root = GetAncestor(hwnd, GA_ROOT);
You can't use GetAncestor here, since this will break for dialog boxes and
constrained windows, all of which represent multi-level views::Window
hierarchies.

You need to navigate up manually using GetParent I think.

[Ben Goodger (Google), 2009-04-29 19:32:31]

OK