Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Side by Side Diff: chrome/browser/external_tab_container.h

Issue 99133: Removes an unused boolean passed to MoveToFront. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/browser/external_tab_container.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_EXTERNAL_TAB_CONTAINER_H_ 5 #ifndef CHROME_BROWSER_EXTERNAL_TAB_CONTAINER_H_
6 #define CHROME_BROWSER_EXTERNAL_TAB_CONTAINER_H_ 6 #define CHROME_BROWSER_EXTERNAL_TAB_CONTAINER_H_
7 7
8 #include <atlbase.h> 8 #include <atlbase.h>
9 #include <atlapp.h> 9 #include <atlapp.h>
10 #include <atlcrack.h> 10 #include <atlcrack.h>
(...skipping 86 matching lines...) Expand 10 before | Expand all | Expand 10 after
97 97
98 // Notification service callback. 98 // Notification service callback.
99 virtual void Observe(NotificationType type, 99 virtual void Observe(NotificationType type,
100 const NotificationSource& source, 100 const NotificationSource& source,
101 const NotificationDetails& details); 101 const NotificationDetails& details);
102 102
103 ///////////////////////////////////////////////////////////////////////////// 103 /////////////////////////////////////////////////////////////////////////////
104 // views::Widget 104 // views::Widget
105 ///////////////////////////////////////////////////////////////////////////// 105 /////////////////////////////////////////////////////////////////////////////
106 virtual void GetBounds(gfx::Rect* out, bool including_frame) const; 106 virtual void GetBounds(gfx::Rect* out, bool including_frame) const;
107 virtual void MoveToFront(bool should_activate);
108 virtual gfx::NativeView GetNativeView() const; 107 virtual gfx::NativeView GetNativeView() const;
109 virtual void PaintNow(const gfx::Rect& update_rect); 108 virtual void PaintNow(const gfx::Rect& update_rect);
110 virtual views::RootView* GetRootView(); 109 virtual views::RootView* GetRootView();
111 virtual bool IsVisible() const; 110 virtual bool IsVisible() const;
112 virtual bool IsActive() const; 111 virtual bool IsActive() const;
113 virtual bool GetAccelerator(int cmd_id, 112 virtual bool GetAccelerator(int cmd_id,
114 views::Accelerator* accelerator) { 113 views::Accelerator* accelerator) {
115 return false; 114 return false;
116 } 115 }
117 116
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
162 // A failed navigation like a 404 is followed in chrome with a success 161 // A failed navigation like a 404 is followed in chrome with a success
163 // navigation for the 404 page. We need to ignore the next navigation 162 // navigation for the 404 page. We need to ignore the next navigation
164 // to avoid confusing the clients of the external tab. This member variable 163 // to avoid confusing the clients of the external tab. This member variable
165 // is set when we need to ignore the next load notification. 164 // is set when we need to ignore the next load notification.
166 bool ignore_next_load_notification_; 165 bool ignore_next_load_notification_;
167 166
168 DISALLOW_COPY_AND_ASSIGN(ExternalTabContainer); 167 DISALLOW_COPY_AND_ASSIGN(ExternalTabContainer);
169 }; 168 };
170 169
171 #endif // CHROME_BROWSER_EXTERNAL_TAB_CONTAINER_H_ 170 #endif // CHROME_BROWSER_EXTERNAL_TAB_CONTAINER_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/external_tab_container.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698