Issue 99128: Allow File>Open File with no window open.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 99128: Allow File>Open File with no window open. (Closed)

Created:
11 years, 7 months ago by Avi (use Gerrit)

Modified:
9 years, 7 months ago

Reviewers:
pink (ping after 24hrs)

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Allow File>Open File with no window open. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=14737

Patch Set 1 #

Total comments: 2

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	chrome/browser/app_controller_mac.mm	View		2 chunks	+6 lines, -0 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

pink (ping after 24hrs)

LGTM w/ question. http://codereview.chromium.org/99128/diff/1/2 File chrome/browser/app_controller_mac.mm (right): http://codereview.chromium.org/99128/diff/1/2#newcode125 Line 125: Browser::OpenEmptyWindow(default_profile); are you sure this ...

11 years, 7 months ago (2009-04-28 16:12:12 UTC) #2

Avi (use Gerrit)

http://codereview.chromium.org/99128/diff/1/2 File chrome/browser/app_controller_mac.mm (right): http://codereview.chromium.org/99128/diff/1/2#newcode125 Line 125: Browser::OpenEmptyWindow(default_profile); On 2009/04/28 16:12:12, pink wrote: > are ...

11 years, 7 months ago (2009-04-28 16:15:55 UTC) #3

This works fine.

Expand Messages | Collapse Messages