Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2475)

Unified Diff: chrome/browser/app_controller_mac.mm

Issue 99128: Allow File>Open File with no window open. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/app_controller_mac.mm
===================================================================
--- chrome/browser/app_controller_mac.mm (revision 14731)
+++ chrome/browser/app_controller_mac.mm (working copy)
@@ -121,6 +121,11 @@
case IDC_NEW_INCOGNITO_WINDOW:
Browser::OpenURLOffTheRecord(default_profile, GURL());
break;
+ case IDC_OPEN_FILE:
+ Browser::OpenEmptyWindow(default_profile);
pink (ping after 24hrs) 2009/04/28 16:12:12 are you sure this is synchronous?
Avi (use Gerrit) 2009/04/28 16:15:56 No. That's why I was trying it out to see if it wo
+ BrowserList::GetLastActive()->
+ ExecuteCommandWithDisposition(IDC_OPEN_FILE, CURRENT_TAB);
+ break;
};
}
@@ -146,6 +151,7 @@
menuState_ = new CommandUpdater(NULL);
menuState_->UpdateCommandEnabled(IDC_NEW_WINDOW, true);
menuState_->UpdateCommandEnabled(IDC_NEW_INCOGNITO_WINDOW, true);
+ menuState_->UpdateCommandEnabled(IDC_OPEN_FILE, true);
// TODO(pinkerton): ...more to come...
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698