Issue 99072: Add an optional flag to gcl.ReadFile() so that presubmit can support CRLF PRE...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 99072: Add an optional flag to gcl.ReadFile() so that presubmit can support CRLF PRE... (Closed)

Created:
11 years, 8 months ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
jam

CC:
chromium-reviews_googlegroups.com, Jeff Bailey

Base URL:
svn://chrome-svn.corp.google.com/chrome/trunk/tools/

Visibility:
Public.

Description

Add an optional flag to gcl.ReadFile() so that presubmit can support CRLF PRESUBMIT.py scripts. Also add a version number to gcl.py. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=14644

Patch Set 1 #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -5 lines)			Patch
M	depot_tools/gcl.py	View	3 chunks	+7 lines, -2 lines	0 comments	Download
M	depot_tools/presubmit.py	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	depot_tools/tests/presubmit_unittest.py	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

jam

11 years, 8 months ago (2009-04-27 20:28:03 UTC) #2

ok (although I don't really understand why this is needed.  I thought we wanted
to avoid checking in CRLF files, is there a reason why presubmit files would be
an exception?

Expand Messages | Collapse Messages