Add an optional flag to gcl.ReadFile() so that presubmit can support CRLF PRE...

depot_tools/gcl.py

 #!/usr/bin/python
 # Copyright (c) 2006-2009 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 #
 # Wrapper script around Rietveld's upload.py that groups files into
 # changelists.
 
 import getpass
 import os
 import random
 import re
 import string
 import subprocess
 import sys
 import tempfile
 import upload
 import urllib2
 
+
+__version__ = '1.0'
+
+
 CODEREVIEW_SETTINGS = {
   # Default values.
   "CODE_REVIEW_SERVER": "codereview.chromium.org",
   "CC_LIST": "chromium-reviews@googlegroups.com",
   "VIEW_VC": "http://src.chromium.org/viewvc/chrome?view=rev&revision=",
 }
 
 # Use a shell for subcommands on Windows to get a PATH search, and because svn
 # may be a batch file.
 use_shell = sys.platform.startswith("win")
@@ skipping 162 matching lines @@
   p.wait()
   p.stdout.close()
   return output, p.returncode
 
 
 def RunShell(command, print_output=False):
   """Executes a command and returns the output."""
   return RunShellWithReturnCode(command, print_output)[0]
 
 
-def ReadFile(filename):
+def ReadFile(filename, flags='r'):
   """Returns the contents of a file."""
-  file = open(filename, 'r')
+  file = open(filename, flags)
   result = file.read()
   file.close()
   return result
 
 
 def WriteFile(filename, contents):
   """Overwrites the file with the given contents."""
   file = open(filename, 'w')
   file.write(contents)
   file.close()
@@ skipping 350 matching lines @@
       print "".join(file)
 
 
 def Help(argv=None):
   if argv and  argv[0] == 'try':
     TryChange(None, ['--help'], swallow_exception=False)
     return
 
   print (
 """GCL is a wrapper for Subversion that simplifies working with groups of files.
+version """ + __version__ + """
 
 Basic commands:
 -----------------------------------------
    gcl change change_name
       Add/remove files to a changelist. Only scans the current directory and
       subdirectories.
 
    gcl upload change_name [-r reviewer1@gmail.com,reviewer2@gmail.com,...]
                           [--send_mail] [--no_try] [--no_presubmit]
       Uploads the changelist to the server for review.
@@ skipping 507 matching lines @@
     # the files. This allows commands such as 'gcl diff xxx' to work.
     args =["svn", command]
     root = GetRepositoryRoot()
     args.extend([os.path.join(root, x) for x in change_info.FileList()])
     RunShell(args, True)
   return 0
 
 
 if __name__ == "__main__":
   sys.exit(main())