Issue 99019: Disable web-fonts, WebKit side....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 99019: Disable web-fonts, WebKit side.... (Closed)

Created:
11 years, 8 months ago by Mark Larson

Modified:
9 years, 7 months ago

Reviewers:
jungshik at Google, dglazkov

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn.corp.google.com/chrome/branches/172/src/

Visibility:
Public.

Description

Disable web-fonts, WebKit side. See also http://codereview.chromium.org/100012 for the Chrome side. Add a flag to Settings to en/disable remote (web) font support in Webkit. (see also https://bugs.webkit.org/show_bug.cgi?id=25239) This is the webkit part of the change. Chrome-part will be in a separate CL. BUG=9633 TBR=jshin Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=14519

Patch Set 1 #

Total comments: 1

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -1 line)			Patch
M	third_party/WebKit/WebCore/css/CSSFontSelector.cpp	View	1 chunk	+1 line, -1 line	1 comment	Download
M	third_party/WebKit/WebCore/page/Settings.h	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	third_party/WebKit/WebCore/page/Settings.cpp	View	2 chunks	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

dglazkov

11 years, 7 months ago (2009-05-15 18:05:57 UTC) #2

Add this check to re-enable SVG fonts.

http://codereview.chromium.org/99019/diff/1/4
File third_party/WebKit/WebCore/css/CSSFontSelector.cpp (right):

http://codereview.chromium.org/99019/diff/1/4#newcode251
Line 251: if (item->isSupportedFormat() && m_document &&
m_document->settings()->remoteFontEnabled()) {
this check should be:

if (item->isSupportedFormat() && (foundSVGFont || (m_document &&
m_document->settings()->remoteFontEnabled()))) {

Expand Messages | Collapse Messages