Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(520)

Issue 100012: Disable web-fonts, Chrome part.... (Closed)

Created:
11 years, 8 months ago by Mark Larson
Modified:
9 years, 7 months ago
Reviewers:
jungshik at Google
CC:
chromium-reviews_googlegroups.com
Base URL:
svn://chrome-svn.corp.google.com/chrome/branches/172/src/
Visibility:
Public.

Description

Disable web-fonts, Chrome part. This applies http://codereview.chromium.org/67210. The patch is different on the 172 branch, so please review carefully. The webkit part will be in another CL. 1. Adds '--enable-remote-font' command line switch 2. Adds a field ('enable_remote_font) to WebPreference 3. Pass the value of enable_remote_font to the corresponding field in WebCore::Settings TBR= jshin BUG=9633 TEST: Run Chrome with and without '--enable-remote-font' command line flag and go to http://www.alistapart.com/d/cssatten/heid.html. Without the flag, the page should be rendered with 'dull-looking ordinary' fonts. With the flag, the page should be rendered with 'decorative' remote fonts. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=14520

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -3 lines) Patch
MM chrome/browser/tab_contents/web_contents.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/common/render_messages.h View 3 chunks +4 lines, -2 lines 0 comments Download
M webkit/glue/webpreferences.h View 2 chunks +3 lines, -1 line 0 comments Download
M webkit/glue/webview_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Mark Larson
11 years, 8 months ago (2009-04-25 06:16:51 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698