Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(559)

Issue 9874016: Reenable GeolocationBrowserTest.TabDestroyed browser test. (Closed)

Created:
8 years, 9 months ago by John Knottenbelt
Modified:
8 years, 8 months ago
Reviewers:
bulach
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Reenable GeolocationBrowserTest.TabDestroyed browser test. This test started to crash and, as a result of fixing the crash, the geolocation infobar code was refactored and improved in http://codereview.chromium.org/9491009 . Hopefully as a result, this test also no longer be flaky. BUG=70588 TEST=GeolocationBrowserTest.TabDestroyed Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=129439 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=130888

Patch Set 1 #

Patch Set 2 : Try to land again. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M chrome/browser/geolocation/geolocation_browsertest.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
John Knottenbelt
Windows try bot also successfully runs this test.
8 years, 9 months ago (2012-03-28 16:02:37 UTC) #1
bulach
lgtm thanks!
8 years, 9 months ago (2012-03-28 16:04:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jknotten@chromium.org/9874016/1
8 years, 9 months ago (2012-03-28 16:05:12 UTC) #3
commit-bot: I haz the power
Change committed as 129439
8 years, 9 months ago (2012-03-28 18:04:14 UTC) #4
John Knottenbelt
Try to reenable this again, now that ASAN-detected problem addressed.
8 years, 8 months ago (2012-04-03 14:02:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jknotten@chromium.org/9874016/13001
8 years, 8 months ago (2012-04-04 09:39:30 UTC) #6
commit-bot: I haz the power
Try job failure for 9874016-13001 (retry) on win_rel for step "browser_tests". It's a second try, ...
8 years, 8 months ago (2012-04-04 12:41:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jknotten@chromium.org/9874016/13001
8 years, 8 months ago (2012-04-04 14:29:01 UTC) #8
commit-bot: I haz the power
Try job failure for 9874016-13001 (retry) on win for step "compile" (clobber build). It's a ...
8 years, 8 months ago (2012-04-04 15:30:01 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jknotten@chromium.org/9874016/13001
8 years, 8 months ago (2012-04-05 09:02:40 UTC) #10
commit-bot: I haz the power
8 years, 8 months ago (2012-04-05 10:43:37 UTC) #11
Change committed as 130888

Powered by Google App Engine
This is Rietveld 408576698