chrome/browser/geolocation/geolocation_browsertest.cc - Issue 9874016: Reenable GeolocationBrowserTest.TabDestroyed browser test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/geolocation/geolocation_browsertest.cc

Issue 9874016: Reenable GeolocationBrowserTest.TabDestroyed browser test. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Try to land again. Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/geolocation/geolocation_browsertest.cc

diff --git a/chrome/browser/geolocation/geolocation_browsertest.cc b/chrome/browser/geolocation/geolocation_browsertest.cc

index e4f4380a94d6e8d1dc855eee8465aa4dc34dd94f..4dbb89094a593c54a6242f8a80915d6fa92afbac 100644

--- a/chrome/browser/geolocation/geolocation_browsertest.cc

+++ b/chrome/browser/geolocation/geolocation_browsertest.cc

@@ -648,8 +648,7 @@ IN_PROC_BROWSER_TEST_F(GeolocationBrowserTest, TwoWatchesInOneFrame) {

CheckGeoposition(final_position_latitude, final_position_longitude);

}

-// Hangs flakily, http://crbug.com/70588.

-IN_PROC_BROWSER_TEST_F(GeolocationBrowserTest, DISABLED_TabDestroyed) {

+IN_PROC_BROWSER_TEST_F(GeolocationBrowserTest, TabDestroyed) {

html_for_tests_ = "files/geolocation/tab_destroyed.html";

ASSERT_TRUE(Initialize(INITIALIZATION_IFRAMES));

LoadIFrames(3);

« no previous file with comments | « no previous file | no next file » | no next file with comments »