Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 9857003: Ash: Fix separator next to 'Other bookmarks' button (Closed)

Created:
8 years, 9 months ago by James Cook
Modified:
8 years, 9 months ago
Reviewers:
sky
CC:
chromium-reviews
Visibility:
Public.

Description

Ash: Fix separator next to 'Other bookmarks' button The bookmarks bar view draws a separator that looks odd with Ash assets. Just hide it for Ash (similar to Mac appearance). BUG=120049 TEST=visual, create bookmarks in the Other bookmarks folder, turn on the bookmarks bar, verify there's no weird separator to the left of 'Other bookmarks' Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=128917

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc View 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
James Cook
Scott, PTAL. This line uses a gradient shader that was color-coordinated with the old art ...
8 years, 9 months ago (2012-03-25 23:08:30 UTC) #1
sky
LGTM
8 years, 9 months ago (2012-03-25 23:09:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/9857003/1
8 years, 9 months ago (2012-03-25 23:14:37 UTC) #3
commit-bot: I haz the power
Try job failure for 9857003-1 (retry) on win_rel for step "browser_tests". It's a second try, ...
8 years, 9 months ago (2012-03-26 01:35:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/9857003/1
8 years, 9 months ago (2012-03-26 14:01:31 UTC) #5
commit-bot: I haz the power
8 years, 9 months ago (2012-03-26 15:28:51 UTC) #6
Change committed as 128917

Powered by Google App Engine
This is Rietveld 408576698