Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4367)

Unified Diff: chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc

Issue 9857003: Ash: Fix separator next to 'Other bookmarks' button (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc
diff --git a/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc b/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc
index 68ebc486096a353509b9097281d4b1cef882af6c..69a8ec53577188d7d5b58a552d4a979539224b68 100644
--- a/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc
+++ b/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc
@@ -1134,6 +1134,11 @@ void BookmarkBarView::Init() {
bookmarks_separator_view_ = new ButtonSeparatorView();
AddChildView(bookmarks_separator_view_);
+#if defined(USE_ASH)
+ // Ash does not paint the bookmarks separator line because it looks odd on
+ // the flat background. We keep it present for layout, but don't draw it.
+ bookmarks_separator_view_->SetVisible(false);
+#endif
instructions_ = new BookmarkBarInstructionsView(this);
AddChildView(instructions_);
@@ -1537,7 +1542,9 @@ void BookmarkBarView::UpdateOtherBookmarksVisibility() {
if (has_other_children == other_bookmarked_button_->visible())
return;
other_bookmarked_button_->SetVisible(has_other_children);
+#if !defined(USE_ASH)
bookmarks_separator_view_->SetVisible(has_other_children);
+#endif
Layout();
SchedulePaint();
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698