Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Issue 9855027: Add gyp variable mac_strip_release to set the target_defaults variable mac_strip. (Closed)

Created:
8 years, 9 months ago by Robert Sesek
Modified:
8 years, 9 months ago
Reviewers:
Mark Mentovai, Nico
CC:
chromium-reviews
Visibility:
Public.

Description

Add gyp variable mac_strip_release to set the target_defaults variable mac_strip. This allows you to do `GYP_DEFINES='mac_strip_release=0' gclient sync` to produce Release binaries that are not run through strip_from_xcode. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=129023

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M build/common.gypi View 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Robert Sesek
8 years, 9 months ago (2012-03-26 18:26:20 UTC) #1
Mark Mentovai
LGTM
8 years, 9 months ago (2012-03-26 19:46:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsesek@chromium.org/9855027/1
8 years, 9 months ago (2012-03-26 19:47:29 UTC) #3
commit-bot: I haz the power
Change committed as 129023
8 years, 9 months ago (2012-03-26 22:22:16 UTC) #4
Nico
Should this default to 0? The bots that build releases need it, but since we ...
8 years, 9 months ago (2012-03-27 16:14:05 UTC) #5
Mark Mentovai
8 years, 9 months ago (2012-03-27 16:20:38 UTC) #6
I’ve resisted that in the past because it’s further from what we ship.

There have been cases where people have actually tried to read the app’s symbol
table to pick up some private symbol or something. Terrible code like that has
no business in our app. If the release-mode symbol table is stripped, it’ll stop
people from trying to do this kind of garbage closer to the source of the bad
idea.

Powered by Google App Engine
This is Rietveld 408576698