Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2633)

Unified Diff: build/common.gypi

Issue 9855027: Add gyp variable mac_strip_release to set the target_defaults variable mac_strip. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index c90d15bb9bae08d61d7e26631751e6588b31f27c..65b8dade1cd46b49d6f3412abcdf7fb9ad26d5dc 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -543,6 +543,10 @@
'mac_sdk%': '10.5',
'mac_deployment_target%': '10.5',
+ # The default value for mac_strip in target_defaults. This cannot be
+ # set there, per the comment about variable% in a target_defaults.
+ 'mac_strip_release%': 1,
+
# Set to 1 to enable code coverage. In addition to build changes
# (e.g. extra CFLAGS), also creates a new target in the src/chrome
# project file called "coverage".
@@ -2394,7 +2398,8 @@
# different targets, like these.
'mac_pie': 1, # Most executables can be position-independent.
'mac_real_dsym': 0, # Fake .dSYMs are fine in most cases.
- 'mac_strip': 1, # Strip debugging symbols from the target.
+ # Strip debugging symbols from the target.
+ 'mac_strip': '<(mac_strip_release)',
},
'mac_bundle': 0,
'xcode_settings': {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698