Issue 9853019: Modify the pure-views slider to reset on ESC.

Issue 9853019: Modify the pure-views slider to reset on ESC. (Closed)

Created:
8 years, 9 months ago by rjkroege

Modified:
7 years, 6 months ago

Reviewers:
sadrul

CC:
chromium-reviews, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Modify the pure-views slider to reset on ESC. Altered the pure-views slide implementation to snapshot its value on start and reset to it on the receipt of an escape key. BUG=119744 TEST=by hand

Patch Set 2 : review comments #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -1 line)			Patch
	M	ui/views/controls/slider.h	View	1	2 chunks	+3 lines, -0 lines	0 comments	Download
	M	ui/views/controls/slider.cc	View	1	5 chunks	+16 lines, -1 line	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

sadrul

http://codereview.chromium.org/9853019/diff/1/ui/views/controls/slider.cc File ui/views/controls/slider.cc (right): http://codereview.chromium.org/9853019/diff/1/ui/views/controls/slider.cc#newcode20 ui/views/controls/slider.cc:20: #include "ui/base/accelerators/accelerator.h" sort http://codereview.chromium.org/9853019/diff/1/ui/views/controls/slider.cc#newcode35 ui/views/controls/slider.cc:35: value_is_valid_(false) { Initialize esc_was_pressed_

8 years, 8 months ago (2012-03-26 22:24:02 UTC) #2

rjkroege

PTAL http://codereview.chromium.org/9853019/diff/1/ui/views/controls/slider.cc File ui/views/controls/slider.cc (right): http://codereview.chromium.org/9853019/diff/1/ui/views/controls/slider.cc#newcode20 ui/views/controls/slider.cc:20: #include "ui/base/accelerators/accelerator.h" On 2012/03/26 22:24:02, sadrul wrote: > ...

8 years, 8 months ago (2012-04-03 19:24:21 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rjkroege@chromium.org/9853019/4001

8 years, 8 months ago (2012-04-03 20:16:57 UTC) #5

commit-bot: I haz the power

Try job failure for 9853019-4001 (previous was lost) (retry) on win_rel for steps "browser_tests, views_unittests". ...

8 years, 8 months ago (2012-04-04 00:09:52 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rjkroege@chromium.org/9853019/4001

8 years, 8 months ago (2012-04-05 17:54:49 UTC) #7

commit-bot: I haz the power

8 years, 8 months ago (2012-04-05 20:44:38 UTC) #8

Try job failure for 9853019-4001 (retry) on win_rel for step "views_unittests".
It's a second try, previously, step "views_unittests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Expand Messages | Collapse Messages