Have URL Modifications sent Regardless of Typed.

chrome/browser/history/url_index_private_data.cc

Index: chrome/browser/history/url_index_private_data.cc
===================================================================
--- chrome/browser/history/url_index_private_data.cc	(revision 131423)
+++ chrome/browser/history/url_index_private_data.cc	(working copy)
@@ -356,7 +356,9 @@
     // The url won't have changed but the title, visit count, etc.
     // might have changed.
     URLRow& row_to_update = row_pos->second;
-    bool title_updated = row_to_update.title() != row.title();
+    // Ignore title changes where new title is empty. (See bug 102957.)

[Peter Kasting, 2012/04/10 02:18:57]

Nit: Instead of referring to a bug, can you put a full explanation here?  (Among
other reasons, it's not instantly clear to me from glancing at the bug what
causes us to get empty new titles here and why we'd actually want to ignore
those.)

[mrossetti, 2012/04/11 19:38:55]

Removed the test for empty(). I cannot now recreate the condition where I saw an
update go by where the title was empty subsequent to an earlier update with a
non-empty title.

On 2012/04/10 02:18:57, Peter Kasting wrote:

+    bool title_updated = row_to_update.title() != row.title() &&
+                         !row.title().empty();
     if (row_to_update.visit_count() != row.visit_count() ||
         row_to_update.typed_count() != row.typed_count() ||
         row_to_update.last_visit() != row.last_visit() || title_updated) {