Have URL Modifications sent Regardless of Typed.

chrome/browser/history/url_index_private_data.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/history/url_index_private_data.h"
 
 #include <algorithm>
 #include <functional>
 #include <iterator>
 #include <limits>
@@ skipping 338 matching lines @@
     // This new row should be indexed if it qualifies.
     URLRow new_row(row);
     new_row.set_id(row_id);
     row_was_updated = RowQualifiesAsSignificant(new_row, base::Time()) &&
                       IndexRow(new_row, languages, scheme_whitelist);
   } else if (RowQualifiesAsSignificant(row, base::Time())) {
     // This indexed row still qualifies and will be re-indexed.
     // The url won't have changed but the title, visit count, etc.
     // might have changed.
     URLRow& row_to_update = row_pos->second;
-    bool title_updated = row_to_update.title() != row.title();
+    // Ignore title changes where new title is empty. (See bug 102957.)

[Peter Kasting, 2012/04/10 02:18:57]

Nit: Instead of referring to a bug, can you put a full explanation here?  (Among
other reasons, it's not instantly clear to me from glancing at the bug what
causes us to get empty new titles here and why we'd actually want to ignore
those.)

[mrossetti, 2012/04/11 19:38:55]

Removed the test for empty(). I cannot now recreate the condition where I saw an
update go by where the title was empty subsequent to an earlier update with a
non-empty title.

On 2012/04/10 02:18:57, Peter Kasting wrote:

+    bool title_updated = row_to_update.title() != row.title() &&
+                         !row.title().empty();
     if (row_to_update.visit_count() != row.visit_count() ||
         row_to_update.typed_count() != row.typed_count() ||
         row_to_update.last_visit() != row.last_visit() || title_updated) {
       row_to_update.set_visit_count(row.visit_count());
       row_to_update.set_typed_count(row.typed_count());
       row_to_update.set_last_visit(row.last_visit());
       // While the URL is guaranteed to remain stable, the title may have
       // changed. If so, then update the index with the changed words.
       if (title_updated) {
         // Clear all words associated with this row and re-index both the
@@ skipping 974 matching lines @@
 }
 
 // static
 bool URLIndexPrivateData::URLSchemeIsWhitelisted(
     const GURL& gurl,
     const std::set<std::string>& whitelist) {
   return whitelist.find(gurl.scheme()) != whitelist.end();
 }
 
 }  // namespace history