Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1004)

Unified Diff: chrome/browser/ui/webui/ntp/ntp_login_handler.cc

Issue 9838064: Add a sign-in promo message to the Other Devices menu. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/ntp/ntp_login_handler.cc
diff --git a/chrome/browser/ui/webui/ntp/ntp_login_handler.cc b/chrome/browser/ui/webui/ntp/ntp_login_handler.cc
index ca8138defe5af6cb0652afc7aed3ff18ca199290..149effc93b1e777648d370d3186161a512c4f6a7 100644
--- a/chrome/browser/ui/webui/ntp/ntp_login_handler.cc
+++ b/chrome/browser/ui/webui/ntp/ntp_login_handler.cc
@@ -233,8 +233,9 @@ void NTPLoginHandler::UpdateLogin() {
StringValue header_value(header);
StringValue sub_header_value(sub_header);
StringValue icon_url_value(icon_url);
- web_ui()->CallJavascriptFunction(
- "ntp.updateLogin", header_value, sub_header_value, icon_url_value);
+ base::FundamentalValue is_user_signed_in(!username.empty());
+ web_ui()->CallJavascriptFunction("ntp.updateLogin",
+ is_user_signed_in, header_value, sub_header_value, icon_url_value);
Dan Beam 2012/03/23 21:12:47 why'd you add a new param to this method at beginn
Patrick Dubroy 2012/03/26 15:16:46 I don't know, I guess I usually try to put more ge
}
// static

Powered by Google App Engine
This is Rietveld 408576698