Add a sign-in promo message to the Other Devices menu.

chrome/browser/ui/webui/ntp/ntp_login_handler.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/ntp/ntp_login_handler.h"
 
 #include <string>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
@@ skipping 215 matching lines @@
           IDS_SYNC_PROMO_NOT_SIGNED_IN_STATUS_SUB_HEADER, signed_in_link);
       // Record that the user was shown the promo.
       RecordInHistogram(NTP_SIGN_IN_PROMO_VIEWED);
     }
 #endif
   }
 
   StringValue header_value(header);
   StringValue sub_header_value(sub_header);
   StringValue icon_url_value(icon_url);
-  web_ui()->CallJavascriptFunction(
-      "ntp.updateLogin", header_value, sub_header_value, icon_url_value);
+  base::FundamentalValue is_user_signed_in(!username.empty());
+  web_ui()->CallJavascriptFunction("ntp.updateLogin",
+      is_user_signed_in, header_value, sub_header_value, icon_url_value);

[Dan Beam, 2012/03/23 21:12:47]

why'd you add a new param to this method at beginning, btw?

[Patrick Dubroy, 2012/03/26 15:16:46]

I don't know, I guess I usually try to put more general parameters first, and
more specific things later. I've never consciously thought about it.

I've moved it to the end.

 }
 
 // static
 bool NTPLoginHandler::ShouldShow(Profile* profile) {
 #if defined(OS_CHROMEOS)
   // For now we don't care about showing sync status on Chrome OS. The promo
   // UI and the avatar menu don't exist on that platform.
   return false;
 #else
   if (profile->IsOffTheRecord())
@@ skipping 16 matching lines @@
       l10n_util::GetStringFUTF16(IDS_SYNC_PROMO_NTP_BUBBLE_MESSAGE,
           l10n_util::GetStringUTF16(IDS_SHORT_PRODUCT_NAME)));
   values->SetString("login_status_url", chrome::kSyncLearnMoreURL);
   values->SetString("login_status_learn_more",
       l10n_util::GetStringUTF16(IDS_LEARN_MORE));
   values->SetString("login_status_advanced",
       l10n_util::GetStringUTF16(IDS_SYNC_PROMO_NTP_BUBBLE_ADVANCED));
   values->SetString("login_status_dismiss",
       l10n_util::GetStringUTF16(IDS_SYNC_PROMO_NTP_BUBBLE_OK));
 }