Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2256)

Unified Diff: chrome/browser/ui/webui/ntp/foreign_session_handler.cc

Issue 9838064: Add a sign-in promo message to the Other Devices menu. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/ntp/foreign_session_handler.cc
diff --git a/chrome/browser/ui/webui/ntp/foreign_session_handler.cc b/chrome/browser/ui/webui/ntp/foreign_session_handler.cc
index 4a6bbaed1601a893c36c1a9f65c796fe3fc52ed2..820774badf783ed2ebe88a1e8f3c1d3aba5913fb 100644
--- a/chrome/browser/ui/webui/ntp/foreign_session_handler.cc
+++ b/chrome/browser/ui/webui/ntp/foreign_session_handler.cc
@@ -99,12 +99,11 @@ void ForeignSessionHandler::HandleGetForeignSessions(const ListValue* args) {
return;
}
- // Note: we don't own the SyncedSessions themselves.
- if (!associator->GetAllForeignSessions(&sessions)) {
- LOG(ERROR) << "ForeignSessionHandler failed to get session data from"
- "SessionModelAssociator.";
+ if (associator->GetAllForeignSessions(&sessions)) {
Dan Beam 2012/03/23 21:12:47 no curlies, also should there be a ! in front of t
Patrick Dubroy 2012/03/26 15:16:46 Ummm...yeah. Nice catch. :-) Done.
return;
}
+
+ // Note: we don't own the SyncedSessions themselves.
int added_count = 0;
ListValue session_list;
for (std::vector<const SyncedSession*>::const_iterator i =

Powered by Google App Engine
This is Rietveld 408576698