Add a sign-in promo message to the Other Devices menu.

chrome/browser/ui/webui/ntp/foreign_session_handler.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/ntp/foreign_session_handler.h"
 
 #include <algorithm>
 #include <string>
 #include <vector>
 #include "base/bind.h"
@@ skipping 77 matching lines @@
   if (!service->ShouldPushChanges())
     return NULL;
   return model_associator;
 }
 
 void ForeignSessionHandler::HandleGetForeignSessions(const ListValue* args) {
   SessionModelAssociator* associator = GetModelAssociator();
   std::vector<const SyncedSession*> sessions;
 
   if (associator == NULL) {
     // Called before associator created, exit.

[Dan Beam, 2012/03/23 21:12:47]

possibly move comment above if, remove curlies and "== NULL" if you feel like
it...

[Patrick Dubroy, 2012/03/26 15:16:46]

Done.

     return;
   }
 
+  if (associator->GetAllForeignSessions(&sessions)) {

[Dan Beam, 2012/03/23 21:12:47]

no curlies, also should there be a ! in front of this?

[Patrick Dubroy, 2012/03/26 15:16:46]

Ummm...yeah. Nice catch. :-) Done.

+    return;
+  }
+
   // Note: we don't own the SyncedSessions themselves.
-  if (!associator->GetAllForeignSessions(&sessions)) {
-    LOG(ERROR) << "ForeignSessionHandler failed to get session data from"
-        "SessionModelAssociator.";
-    return;
-  }
   int added_count = 0;
   ListValue session_list;
   for (std::vector<const SyncedSession*>::const_iterator i =
       sessions.begin(); i != sessions.end() &&
       added_count < kMaxSessionsToShow; ++i) {
     const SyncedSession* session = *i;
     scoped_ptr<DictionaryValue> session_data(new DictionaryValue());
     session_data->SetString("tag", session->session_tag);
     session_data->SetString("name", session->session_name);
     scoped_ptr<ListValue> window_list(new ListValue());
@@ skipping 123 matching lines @@
     return false;
   dictionary->SetString("type", "window");
   dictionary->SetDouble("timestamp",
       static_cast<double>(window.timestamp.ToInternalValue()));
   dictionary->SetInteger("sessionId", window.window_id.id());
   dictionary->Set("tabs", tab_values.release());
   return true;
 }
 
 }  // namespace browser_sync