Issue 9838043: Change the order of visual feedback effect and grabbing screenshot.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9838043: Change the order of visual feedback effect and grabbing screenshot. (Closed)

Created:
8 years, 9 months ago by Jun Mukai

Modified:
8 years, 9 months ago

Reviewers:
Daniel Erat

CC:
chromium-reviews, dhollowa+watch_chromium.org, sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Change the order of visual feedback effect and grabbing screenshot. Because grabbing screenshot takes time, there is noticeable delay between the user's key press and visual feedback. Theoretically there is a risk that visual feedback happens but it fails to take screenshot, but its risk would be quite low. R=derat@chromium.org BUG=119492 TEST=manually Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=128422 Reverted: https://src.chromium.org/viewvc/chrome?view=rev&revision=129475

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -25 lines)			Patch
	M	chrome/browser/ui/views/ash/screenshot_taker.h	View		2 chunks	+6 lines, -4 lines	0 comments	Download
	M	chrome/browser/ui/views/ash/screenshot_taker.cc	View	1	4 chunks	+33 lines, -21 lines	0 comments	Download

Total messages: 2 (0 generated)

lgtm