Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 9838043: Change the order of visual feedback effect and grabbing screenshot. (Closed)

Created:
8 years, 9 months ago by Jun Mukai
Modified:
8 years, 9 months ago
Reviewers:
Daniel Erat
CC:
chromium-reviews, dhollowa+watch_chromium.org, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Change the order of visual feedback effect and grabbing screenshot. Because grabbing screenshot takes time, there is noticeable delay between the user's key press and visual feedback. Theoretically there is a risk that visual feedback happens but it fails to take screenshot, but its risk would be quite low. R=derat@chromium.org BUG=119492 TEST=manually Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=128422 Reverted: https://src.chromium.org/viewvc/chrome?view=rev&revision=129475

Patch Set 1 #

Patch Set 2 : remove unnecessary comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -25 lines) Patch
M chrome/browser/ui/views/ash/screenshot_taker.h View 2 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/ash/screenshot_taker.cc View 1 4 chunks +33 lines, -21 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Jun Mukai
8 years, 9 months ago (2012-03-23 03:53:38 UTC) #1
Daniel Erat
8 years, 9 months ago (2012-03-23 04:34:22 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698