Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Unified Diff: content/test/web_contents_tester.h

Issue 9838009: Clean up a few TODO items. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix compile Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/test/web_contents_tester.h
diff --git a/content/test/web_contents_tester.h b/content/test/web_contents_tester.h
index 1729404858fe62884eea114fcb2b1df42c591f0c..1d5f028571e73ff0cb6968cc5338d5be83d77cba 100644
--- a/content/test/web_contents_tester.h
+++ b/content/test/web_contents_tester.h
@@ -84,8 +84,7 @@ class WebContentsTester {
// in question have been made.
virtual int GetNumberOfFocusCalls() = 0;
- // TODO(joi): Rename this and other hacker_style virtual methods.
- virtual content::RenderViewHost* pending_rvh() const = 0;
+ virtual content::RenderViewHost* GetPendingRvh() const = 0;
jam 2012/03/22 17:15:41 nit: since RVH is an acronym it should be GetPendi
Jói 2012/03/22 17:39:58 Done.
// Creates a pending navigation to the given URL with the default parameters
// and then commits the load with a page ID one larger than any seen. This

Powered by Google App Engine
This is Rietveld 408576698