Move launchd code from chrome/browser/mac to base/mac.

Move launchd code from chrome/browser/mac to base/mac.

This is to allow the code to be used by the Chromoting host plugin.
Also expand the interface of PIDForJob() to report if a job is loaded but not
running.

BUG=None
TEST=Compiles, unit-tests pass

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=129636

[Lambros, 2012-03-28 00:36:05]

Although I "git mv"d 3 files, one of them (launchd.h) is showing up here as a
new file instead of a renamed file. I don't know how to fix this, sorry! :(

I've exported the MessageForJob() function, so I could use it to send a
LAUNCH_KEY_STOPJOB message. Hope this is OK.

Also, I've noticed that a lot of code in base/mac uses the "BASE_EXPORT"
annotation.  Is that required here?

[Mark Mentovai, 2012-03-28 16:37:50]

http://codereview.chromium.org/9837098/diff/12/base/mac/launchd.cc
File base/mac/launchd.cc (right):

http://codereview.chromium.org/9837098/diff/12/base/mac/launchd.cc#newcode64
base/mac/launchd.cc:64: return 0;
Why have you changed this? Now it doesn’t even match the documented behavior.
Please put it back.

[Mark Mentovai, 2012-03-28 16:38:51]

Oh, I see what you intended.

OK, LGTM.

[Avi (use Gerrit), 2012-03-28 16:41:58]

On 2012/03/28 00:36:05, Lambros wrote:
> Also, I've noticed that a lot of code in base/mac uses the "BASE_EXPORT"
> annotation.  Is that required here?

For the component build, if a function is used by something outside of base,
you'll need to tag it as such. I think we're working on getting the component
build working for the Mac, but I don't see any trybots... :(

[Mark Mentovai, 2012-03-28 16:48:06]

Nico’s working on getting an FYI bot set up. He was concerned about
how busty the fixes were getting.
http://codereview.chromium.org/9791049/

If you’re not positive you need BASE_EXPORT, it’s fine to leave off for now.

avi@chromium.org wrote:
> On 2012/03/28 00:36:05, Lambros wrote:
>>
>> Also, I've noticed that a lot of code in base/mac uses the "BASE_EXPORT"
>> annotation.  Is that required here?
>
>
> For the component build, if a function is used by something outside of base,
> you'll need to tag it as such. I think we're working on getting the
> component
> build working for the Mac, but I don't see any trybots... :(
>
> http://codereview.chromium.org/9837098/

[commit-bot: I haz the power, 2012-03-28 18:54:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/lambroslambrou@chromium.org/9837098/12

[commit-bot: I haz the power, 2012-03-28 21:31:58]

Try job failure for 9837098-12 (retry) on win_rel for step "browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2012-03-28 21:41:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/lambroslambrou@chromium.org/9837098/12

[commit-bot: I haz the power, 2012-03-29 00:50:21]

Try job failure for 9837098-12 (retry) on win_rel for step "browser_tests".
It's a second try, previously, steps "browser_tests, installer_util_unittests"
failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2012-03-29 01:29:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/lambroslambrou@chromium.org/9837098/12

[commit-bot: I haz the power, 2012-03-29 04:43:25]

Try job failure for 9837098-12 (retry) on win_rel for step "browser_tests".
It's a second try, previously, steps "ui_tests, browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2012-03-29 05:11:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/lambroslambrou@chromium.org/9837098/12

[commit-bot: I haz the power, 2012-03-29 07:34:20]

Try job failure for 9837098-12 (retry) on win_rel for step "browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...