Move launchd code from chrome/browser/mac to base/mac.

base/mac/launchd.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#include "chrome/browser/mac/launchd.h"
-
-#include <launch.h>
+#include "base/mac/launchd.h"
 
 #include "base/logging.h"
-#include "chrome/browser/mac/scoped_launch_data.h"
+#include "base/mac/scoped_launch_data.h"
 
-namespace launchd {
-
-namespace {
+namespace base {
+namespace mac {
 
 // MessageForJob sends a single message to launchd with a simple dictionary
 // mapping |operation| to |job_label|, and returns the result of calling
 // launch_msg to send that message. On failure, returns NULL. The caller
 // assumes ownership of the returned launch_data_t object.
 launch_data_t MessageForJob(const std::string& job_label,
                             const char* operation) {
   // launch_data_alloc returns something that needs to be freed.
   ScopedLaunchData message(launch_data_alloc(LAUNCH_DATA_DICTIONARY));
   if (!message) {
@@ skipping 13 matching lines @@
 
   if (!launch_data_dict_insert(message,
                                job_label_launchd.release(),
                                operation)) {
     return NULL;
   }
 
   return launch_msg(message);
 }
 
-}  // namespace
-
 pid_t PIDForJob(const std::string& job_label) {
   ScopedLaunchData response(MessageForJob(job_label, LAUNCH_KEY_GETJOB));
   if (!response) {
     return -1;
   }
 
   launch_data_type_t response_type = launch_data_get_type(response);
   if (response_type != LAUNCH_DATA_DICTIONARY) {
     if (response_type == LAUNCH_DATA_ERRNO) {
       LOG(ERROR) << "PIDForJob: error " << launch_data_get_errno(response);
     } else {
       LOG(ERROR) << "PIDForJob: expected dictionary, got " << response_type;
     }
     return -1;
   }
 
   launch_data_t pid_data = launch_data_dict_lookup(response,
                                                    LAUNCH_JOBKEY_PID);
-  if (!pid_data) {
-    LOG(ERROR) << "PIDForJob: no pid";
-    return -1;
-  }
+  if (!pid_data)
+    return 0;

[Mark Mentovai, 2012/03/28 16:37:50]

Why have you changed this? Now it doesn’t even match the documented behavior.
Please put it back.

 
   if (launch_data_get_type(pid_data) != LAUNCH_DATA_INTEGER) {
     LOG(ERROR) << "PIDForJob: expected integer";
     return -1;
   }
 
   return launch_data_get_integer(pid_data);
 }
 
-}  // namespace launchd
+}  // namespace mac
+}  // namespace base