Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9834067: Get more data to diagnose a crash. (Closed)

Created:
8 years, 9 months ago by Charlie Reis
Modified:
8 years, 9 months ago
Reviewers:
eroman, jam
CC:
chromium-reviews, Avi (use Gerrit), creis+watch_chromium.org, ajwong+watch_chromium.org, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Get more data to diagnose a crash. BUG=72235 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=128683

Patch Set 1 : Initial CL #

Total comments: 2

Patch Set 2 : Add bug number to comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M content/browser/tab_contents/tab_contents.cc View 1 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Charlie Reis
8 years, 9 months ago (2012-03-23 21:30:39 UTC) #1
eroman
lgtm
8 years, 9 months ago (2012-03-23 21:35:42 UTC) #2
Charlie Reis
Thanks. John, can you review for owner's approval?
8 years, 9 months ago (2012-03-23 21:39:54 UTC) #3
jam
lgtm https://chromiumcodereview.appspot.com/9834067/diff/2001/content/browser/tab_contents/tab_contents.cc File content/browser/tab_contents/tab_contents.cc (right): https://chromiumcodereview.appspot.com/9834067/diff/2001/content/browser/tab_contents/tab_contents.cc#newcode1068 content/browser/tab_contents/tab_contents.cc:1068: // Log the URL to help us diagnose ...
8 years, 9 months ago (2012-03-23 22:12:38 UTC) #4
Charlie Reis
Thanks! https://chromiumcodereview.appspot.com/9834067/diff/2001/content/browser/tab_contents/tab_contents.cc File content/browser/tab_contents/tab_contents.cc (right): https://chromiumcodereview.appspot.com/9834067/diff/2001/content/browser/tab_contents/tab_contents.cc#newcode1068 content/browser/tab_contents/tab_contents.cc:1068: // Log the URL to help us diagnose ...
8 years, 9 months ago (2012-03-23 22:23:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/creis@chromium.org/9834067/1003
8 years, 9 months ago (2012-03-23 22:59:09 UTC) #6
commit-bot: I haz the power
8 years, 9 months ago (2012-03-24 04:12:24 UTC) #7 
Change committed as 128683

Powered by Google App Engine
This is Rietveld 408576698