Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2266)

Unified Diff: content/browser/tab_contents/tab_contents.cc

Issue 9834067: Get more data to diagnose a crash. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add bug number to comment Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/tab_contents/tab_contents.cc
diff --git a/content/browser/tab_contents/tab_contents.cc b/content/browser/tab_contents/tab_contents.cc
index bf9f813d53e8d60967e8b9b3aafc20ea317449e2..70f647b6812398769e145169f56001a343cd2bf3 100644
--- a/content/browser/tab_contents/tab_contents.cc
+++ b/content/browser/tab_contents/tab_contents.cc
@@ -1063,8 +1063,12 @@ bool TabContents::NavigateToEntry(
#if defined(OS_CHROMEOS)
is_allowed_in_web_ui_renderer |= entry.GetURL().SchemeIs(chrome::kDataScheme);
#endif
- CHECK(!(enabled_bindings & content::BINDINGS_POLICY_WEB_UI) ||
- is_allowed_in_web_ui_renderer);
+ if ((enabled_bindings & content::BINDINGS_POLICY_WEB_UI) &&
+ !is_allowed_in_web_ui_renderer) {
+ // Log the URL to help us diagnose http://crbug.com/72235.
+ content::GetContentClient()->SetActiveURL(entry.GetURL());
+ CHECK(0);
+ }
// Tell DevTools agent that it is attached prior to the navigation.
DevToolsManagerImpl::GetInstance()->OnNavigatingToPendingEntry(
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698