Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 9834052: [strace] Add support for interrupted calls and proper chdir handling. (Closed)

Created:
8 years, 9 months ago by M-A Ruel
Modified:
8 years, 9 months ago
CC:
chromium-reviews, pam+watch_chromium.org, csharp
Visibility:
Public.

Description

[strace] Add support for interrupted calls and proper chdir handling. Add support to log a trace without specifying the command line with --from-results to simplify repeated testing. Now uses a whitelist for strace log parser to throw on any unknown line. Add symlink resolving. R=rogerta@chromium.org BUG=98834 TEST= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=129407

Patch Set 1 #

Patch Set 2 : comment #

Patch Set 3 : Fix --force #

Patch Set 4 : unit_tests tries to open an empty file "" so adapt the regexp #

Patch Set 5 : Fix isolate.py --mode=trace to use the proper variables #

Total comments: 2

Patch Set 6 : Fix unit test to ignore unexpected files, add back previous behavior to always set cwd to --root-di… #

Patch Set 7 : Fix test again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+289 lines, -82 lines) Patch
M tools/isolate/isolate.py View 1 2 3 4 8 chunks +42 lines, -17 lines 0 comments Download
M tools/isolate/isolate_test.py View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M tools/isolate/trace_inputs.py View 1 2 3 4 5 12 chunks +184 lines, -53 lines 0 comments Download
M tools/isolate/trace_inputs_test.py View 1 2 3 4 5 6 5 chunks +62 lines, -12 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
M-A Ruel
With chdir() and clone() support, this gives a pretty strong long parsing facility on linux. ...
8 years, 9 months ago (2012-03-23 16:36:32 UTC) #1
M-A Ruel
Dependent on http://codereview.chromium.org/9834052.
8 years, 9 months ago (2012-03-24 15:51:55 UTC) #2
M-A Ruel
On 2012/03/24 15:51:55, Marc-Antoine Ruel wrote: > Dependent on http://codereview.chromium.org/9834052. ignore ^^.
8 years, 9 months ago (2012-03-24 15:52:07 UTC) #3
Roger Tawa OOO till Jul 10th
lgtm http://codereview.chromium.org/9834052/diff/7001/tools/isolate/trace_inputs.py File tools/isolate/trace_inputs.py (right): http://codereview.chromium.org/9834052/diff/7001/tools/isolate/trace_inputs.py#newcode182 tools/isolate/trace_inputs.py:182: def gen_trace(cls, cmd, cwd, logname): for my own ...
8 years, 9 months ago (2012-03-27 15:52:53 UTC) #4
M-A Ruel
http://codereview.chromium.org/9834052/diff/7001/tools/isolate/trace_inputs.py File tools/isolate/trace_inputs.py (right): http://codereview.chromium.org/9834052/diff/7001/tools/isolate/trace_inputs.py#newcode182 tools/isolate/trace_inputs.py:182: def gen_trace(cls, cmd, cwd, logname): On 2012/03/27 15:52:53, Roger ...
8 years, 9 months ago (2012-03-27 15:58:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/9834052/7001
8 years, 9 months ago (2012-03-27 16:49:33 UTC) #6
commit-bot: I haz the power
Presubmit check for 9834052-7001 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 9 months ago (2012-03-27 16:49:44 UTC) #7
M-A Ruel
On 2012/03/27 16:49:44, I haz the power (commit-bot) wrote: > File > "/mnt/data/b/commit-queue/workdir/chromium/tools/isolate/trace_inputs_test.py", > line ...
8 years, 9 months ago (2012-03-27 16:53:13 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/9834052/12002
8 years, 9 months ago (2012-03-27 17:12:15 UTC) #9
commit-bot: I haz the power
Presubmit check for 9834052-12002 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 9 months ago (2012-03-27 17:12:30 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/9834052/10002
8 years, 9 months ago (2012-03-27 17:28:20 UTC) #11
commit-bot: I haz the power
8 years, 9 months ago (2012-03-27 22:56:56 UTC) #12
Try job failure for 9834052-10002 (retry) on win_rel for step "browser_tests".
It's a second try, previously, steps "ui_tests, browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Powered by Google App Engine
This is Rietveld 408576698