Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1030)

Unified Diff: chrome/browser/chromeos/system/ash_system_tray_delegate.cc

Issue 9829007: chromeos: Fix a crash when trying to open settings page when there is no browser window. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/system/ash_system_tray_delegate.cc
diff --git a/chrome/browser/chromeos/system/ash_system_tray_delegate.cc b/chrome/browser/chromeos/system/ash_system_tray_delegate.cc
index cd6f7389f7cff58dd9294b0e7de4acf9db28a53a..63a8659a7e930af6ad98a0d38a71fde9636832e2 100644
--- a/chrome/browser/chromeos/system/ash_system_tray_delegate.cc
+++ b/chrome/browser/chromeos/system/ash_system_tray_delegate.cc
@@ -418,8 +418,10 @@ class SystemTrayDelegate : public ash::SystemTrayDelegate,
// browser window with an empty tab and returns it.
Browser* GetAppropriateBrowser() {
Browser* browser = BrowserList::GetLastActive();
- if (!browser)
- browser = Browser::NewEmptyWindow(ProfileManager::GetDefaultProfile());
+ if (!browser) {
+ Profile* profile = ProfileManager::GetDefaultProfile();
+ browser = Browser::OpenEmptyWindow(profile->GetOriginalProfile());
sky 2012/03/22 00:40:09 I think this is the wrong thing when not signed in
sadrul 2012/03/22 00:46:40 Ah, good point. I'll wait for that CL to land.
+ }
return browser;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698