chromeos: Fix a crash when trying to open settings page when there is no browser window.

chrome/browser/chromeos/system/ash_system_tray_delegate.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/system/ash_system_tray_delegate.h"
 
 #include "ash/shell.h"
 #include "ash/shell_window_ids.h"
 #include "ash/system/audio/audio_observer.h"
 #include "ash/system/bluetooth/bluetooth_observer.h"
@@ skipping 400 matching lines @@
   virtual void ChangeProxySettings() OVERRIDE {
     CHECK(GetUserLoginStatus() == ash::user::LOGGED_IN_NONE);
     BaseLoginDisplayHost::default_host()->OpenProxySettings();
   }
 
  private:
   // Returns the last active browser. If there is no such browser, creates a new
   // browser window with an empty tab and returns it.
   Browser* GetAppropriateBrowser() {
     Browser* browser = BrowserList::GetLastActive();
-    if (!browser)
-      browser = Browser::NewEmptyWindow(ProfileManager::GetDefaultProfile());
+    if (!browser) {
+      Profile* profile = ProfileManager::GetDefaultProfile();
+      browser = Browser::OpenEmptyWindow(profile->GetOriginalProfile());

[sky, 2012/03/22 00:40:09]

I think this is the wrong thing when not signed in. I think you want
GetDefaultProfileOrOffTheRecord which sadly hasn't landed yet. It's at
http://codereview.chromium.org/9691032 .

[sadrul, 2012/03/22 00:46:40]

Ah, good point. I'll wait for that CL to land.

+    }
     return browser;
   }
 
   void SetProfile(Profile* profile) {
     pref_registrar_.reset(new PrefChangeRegistrar);
     pref_registrar_->Init(profile->GetPrefs());
     pref_registrar_->Add(prefs::kUse24HourClock, this);
     UpdateClockType(profile->GetPrefs());
   }
 
@@ skipping 279 matching lines @@
   DISALLOW_COPY_AND_ASSIGN(SystemTrayDelegate);
 };
 
 }  // namespace
 
 ash::SystemTrayDelegate* CreateSystemTrayDelegate(ash::SystemTray* tray) {
   return new chromeos::SystemTrayDelegate(tray);
 }
 
 }  // namespace chromeos