Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(686)

Unified Diff: base/tracked_objects.h

Issue 9818004: Cleanup: Replace 'DurationInt' with int32, and always use 32-bit integers for tracking time. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/tracked_objects.h
diff --git a/base/tracked_objects.h b/base/tracked_objects.h
index cd5059421504bf37c53196b78ed8d458da915a96..e09b70b303f4fb4b96777d2e4bc768ad7ef5afee 100644
--- a/base/tracked_objects.h
+++ b/base/tracked_objects.h
@@ -261,18 +261,18 @@ class BASE_EXPORT DeathData {
// Update stats for a task destruction (death) that had a Run() time of
// |duration|, and has had a queueing delay of |queue_duration|.
- void RecordDeath(const DurationInt queue_duration,
- const DurationInt run_duration,
+ void RecordDeath(const int32 queue_duration,
+ const int32 run_duration,
int random_number);
// Metrics accessors, used only in tests.
int count() const;
- DurationInt run_duration_sum() const;
- DurationInt run_duration_max() const;
- DurationInt run_duration_sample() const;
- DurationInt queue_duration_sum() const;
- DurationInt queue_duration_max() const;
- DurationInt queue_duration_sample() const;
+ int32 run_duration_sum() const;
+ int32 run_duration_max() const;
+ int32 run_duration_sample() const;
+ int32 queue_duration_sum() const;
+ int32 queue_duration_max() const;
+ int32 queue_duration_sample() const;
// Construct a DictionaryValue instance containing all our stats. The caller
// assumes ownership of the returned instance.
@@ -290,16 +290,16 @@ class BASE_EXPORT DeathData {
// Number of runs seen (divisor for calculating averages).
int count_;
// Basic tallies, used to compute averages.
- DurationInt run_duration_sum_;
- DurationInt queue_duration_sum_;
+ int32 run_duration_sum_;
+ int32 queue_duration_sum_;
// Max values, used by local visualization routines. These are often read,
// but rarely updated.
- DurationInt run_duration_max_;
- DurationInt queue_duration_max_;
+ int32 run_duration_max_;
+ int32 queue_duration_max_;
// Samples, used by by crowd sourcing gatherers. These are almost never read,
// and rarely updated.
- DurationInt run_duration_sample_;
- DurationInt queue_duration_sample_;
+ int32 run_duration_sample_;
+ int32 queue_duration_sample_;
};
//------------------------------------------------------------------------------
@@ -514,9 +514,7 @@ class BASE_EXPORT ThreadData {
Births* TallyABirth(const Location& location);
// Find a place to record a death on this thread.
- void TallyADeath(const Births& birth,
- DurationInt queue_duration,
- DurationInt duration);
+ void TallyADeath(const Births& birth, int32 queue_duration, int32 duration);
// Using our lock, make a copy of the specified maps. This call may be made
// on non-local threads, which necessitate the use of the lock to prevent

Powered by Google App Engine
This is Rietveld 408576698