Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Unified Diff: base/profiler/tracked_time.h

Issue 9818004: Cleanup: Replace 'DurationInt' with int32, and always use 32-bit integers for tracking time. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/profiler/tracked_time.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/profiler/tracked_time.h
diff --git a/base/profiler/tracked_time.h b/base/profiler/tracked_time.h
index 5493e2068739b31ebc59c3ccf1e63ebab6364015..b96bfa25202315d7b297b615d622f66a0fafaaea 100644
--- a/base/profiler/tracked_time.h
+++ b/base/profiler/tracked_time.h
@@ -12,14 +12,8 @@
namespace tracked_objects {
-typedef int DurationInt;
-
//------------------------------------------------------------------------------
-#define USE_FAST_TIME_CLASS_FOR_DURATION_CALCULATIONS
Ilya Sherman 2012/03/21 21:47:49 I should mention: I'm not sure if this #define is
jar (doing other things) 2012/03/23 05:28:58 I don't see us going back... so this is fine to ki
-
-#if defined(USE_FAST_TIME_CLASS_FOR_DURATION_CALCULATIONS)
-
// TimeTicks maintains a wasteful 64 bits of data (we need less than 32), and on
// windows, a 64 bit timer is expensive to even obtain. We use a simple
// millisecond counter for most of our time values, as well as millisecond units
@@ -72,17 +66,6 @@ class BASE_EXPORT TrackedTime { // Similar to base::TimeTicks.
uint32 ms_;
};
-#else
-
-// Just use full 64 bit time calculations, and the slower TimeTicks::Now().
-// This allows us (as an alternative) to test with larger ranges of times, and
-// with a more thoroughly tested class.
-
-typedef base::TimeTicks TrackedTime;
-typedef base::TimeDelta Duration;
-
-#endif // USE_FAST_TIME_CLASS_FOR_DURATION_CALCULATIONS
-
} // namespace tracked_objects
#endif // BASE_PROFILER_TRACKED_TIME_H_
« no previous file with comments | « no previous file | base/profiler/tracked_time.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698