Cleanup: Replace 'DurationInt' with int32, and always use 32-bit integers for tracking time.

Cleanup: Replace 'DurationInt' with int32, and always use 32-bit integers for tracking time.

BUG=none
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=128783

[Ilya Sherman, 2012-03-21 21:47:48]

https://chromiumcodereview.appspot.com/9818004/diff/1/base/profiler/tracked_t...
File base/profiler/tracked_time.h (left):

https://chromiumcodereview.appspot.com/9818004/diff/1/base/profiler/tracked_t...
base/profiler/tracked_time.h:19: #define
USE_FAST_TIME_CLASS_FOR_DURATION_CALCULATIONS
I should mention: I'm not sure if this #define is still something that you think
is valuable to toggle on and off.  If it is, I'll remove its removal from this
CL.

[jar (doing other things), 2012-03-23 05:28:58]

Switching to int32 is clearly good fro the DurationInts.

I often prefer to use a typedef, which is descriptive, in preference to a "raw
type" (even an int32).  It often helps with readability, especially when the
same raw type is used nearby for other things.  I *was* a little afraid that
this change would hurt.

...but...

Reading the CL, the variable names that we apply the type to are seemingly quite
clear. (I don't think I see a justifcation for keeping the typedef).

If you don't see any reason to keep the typedef, then LGTM.  If you have any
qualms, I'd suggest leaving the typedef, but killing the FAST_TIME option (as
you did below).

https://chromiumcodereview.appspot.com/9818004/diff/1/base/profiler/tracked_t...
File base/profiler/tracked_time.h (left):

https://chromiumcodereview.appspot.com/9818004/diff/1/base/profiler/tracked_t...
base/profiler/tracked_time.h:19: #define
USE_FAST_TIME_CLASS_FOR_DURATION_CALCULATIONS
I don't see us going back... so this is fine to kill.  There was a tiny chance
that we'd make a faster time class (perhaps centered on the message loop...
using TLS there)... but if/when we do... this code will all be gone.

On 2012/03/21 21:47:49, Ilya Sherman wrote:
> I should mention: I'm not sure if this #define is still something that you
think
> is valuable to toggle on and off.  If it is, I'll remove its removal from this
> CL.

[commit-bot: I haz the power, 2012-03-23 22:00:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/isherman@chromium.org/9818004/1

[commit-bot: I haz the power, 2012-03-24 03:36:38]

Try job failure for 9818004-1 (previous was lost) (retry) on win_rel for steps
"ui_tests, browser_tests" (clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2012-03-24 20:00:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/isherman@chromium.org/9818004/1

[commit-bot: I haz the power, 2012-03-24 22:17:20]

Change committed as 128783