Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3906)

Unified Diff: chrome/common/extensions/extension_constants.cc

Issue 9812008: Polish the keybinding implementation a bit. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/extension_constants.cc
===================================================================
--- chrome/common/extensions/extension_constants.cc (revision 127690)
+++ chrome/common/extensions/extension_constants.cc (working copy)
@@ -98,6 +98,9 @@
const char kShiftKey[] = "shiftKey";
const char kShortcutKey[] = "shortcutKey";
const char kSignature[] = "signature";
+const char kSuggestedKeyMac[] = "suggested_key_mac";
+const char kSuggestedKeyOther[] = "suggested_key_other";
+const char kSuggestedKeyWin[] = "suggested_key_win";
const char kTheme[] = "theme";
const char kThemeColors[] = "colors";
const char kThemeDisplayProperties[] = "properties";
@@ -125,7 +128,7 @@
} // namespace extension_manifest_keys
namespace extension_manifest_values {
-const char kBrowserActionKeybindingEvent[] = "browserAction";
+const char kBrowserActionKeybindingEvent[] = "_execute_browser_action";
const char kIncognitoSplit[] = "split";
const char kIncognitoSpanning[] = "spanning";
const char kIntentDispositionWindow[] = "window";
@@ -134,7 +137,7 @@
const char kRunAtDocumentStart[] = "document_start";
const char kRunAtDocumentEnd[] = "document_end";
const char kRunAtDocumentIdle[] = "document_idle";
-const char kPageActionKeybindingEvent[] = "pageAction";
+const char kPageActionKeybindingEvent[] = "_execute_page_action";
const char kPageActionTypeTab[] = "tab";
const char kPageActionTypePermanent[] = "permanent";
const char kLaunchContainerPanel[] = "panel";
@@ -294,7 +297,7 @@
const char kInvalidKey[] =
"Value 'key' is missing or invalid.";
const char kInvalidKeyBinding[] =
- "Invalid value for 'commands[*].key':";
+ "Invalid value for 'commands[*].*': *.";
const char kInvalidKeyBindingDescription[] =
"Invalid value for 'commands[*].description'.";
const char kInvalidKeyBindingDictionary[] =

Powered by Google App Engine
This is Rietveld 408576698