Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7840)

Unified Diff: chrome/common/extensions/extension_unittest.cc

Issue 9812008: Polish the keybinding implementation a bit. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/extension_unittest.cc
===================================================================
--- chrome/common/extensions/extension_unittest.cc (revision 127690)
+++ chrome/common/extensions/extension_unittest.cc (working copy)
@@ -970,20 +970,18 @@
// Case insensitivity is OK.
{ true, CtrlF, "command", "Ctrl+F", "description" },
{ true, CtrlF, "command", "cTrL+f", "description" },
- // Extra spaces are fine.
- { true, CtrlShiftF, "command", " Ctrl + Shift +F", "description" },
- // Minus is equivalent to plus.
- { true, CtrlShiftF, "command", "Ctrl+Shift-F", "description" },
// Skipping description is OK for browser- and pageActions.
- { true, CtrlF, "browserAction", "Ctrl+F", "" },
- { true, CtrlF, "pageAction", "Ctrl+F", "" },
+ { true, CtrlF, "_execute_browser_action", "Ctrl+F", "" },
+ { true, CtrlF, "_execute_page_action", "Ctrl+F", "" },
};
// TODO(finnur): test Command/Options on Mac when implemented.
for (size_t i = 0; i < ARRAYSIZE_UNSAFE(kTests); ++i) {
scoped_ptr<DictionaryValue> command(new DictionaryValue);
- command->SetString("key", kTests[i].key);
+ command->SetString("suggested_key_win", kTests[i].key);
+ command->SetString("suggested_key_mac", kTests[i].key);
+ command->SetString("suggested_key_other", kTests[i].key);
command->SetString("description", kTests[i].description);
Extension::ExtensionKeybinding keybinding;

Powered by Google App Engine
This is Rietveld 408576698