Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Unified Diff: chrome/test/data/workers/terminate_queued_workers.html

Issue 9802025: Rewrite HTML5 workers ui_tests to browser_tests. Compared to ui_tests, browser_tests are faster, le… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: add directory create call needed on linux Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/workers/terminate_queued_workers.html
===================================================================
--- chrome/test/data/workers/terminate_queued_workers.html (revision 129415)
+++ chrome/test/data/workers/terminate_queued_workers.html (working copy)
@@ -8,7 +8,7 @@
var workers = [];
function startAndTerminateWorkers() {
var terminateCount = 0;
- for (var i = 0 ; i < 200 ; i++) {
+ for (var i = 0 ; i < 16 ; i++) {
var w = new Worker("worker_common.js");
workers.push(w);
w.postMessage("ping");
@@ -17,11 +17,6 @@
if (terminateCount == 16) {
shutdownWorkers();
}
- if (terminateCount > 16) {
- // Should not get more than 16 messages back unless we raise the worker
- // limit.
Andrew T Wilson (Slow) 2012/03/28 22:44:09 Why did we get rid of this check? Was it race-y?
jam 2012/03/28 23:01:27 now we can run more than 16 workers with isolates
Andrew T Wilson (Slow) 2012/03/28 23:49:27 Note that now this test doesn't actually do much u
jam 2012/03/29 01:03:41 good point. I tried to switch it to a SharedWorker
- onFailure();
- }
}
}
}

Powered by Google App Engine
This is Rietveld 408576698