chrome/test/data/workers/terminate_queued_workers.html - Issue 9802025: Rewrite HTML5 workers ui_tests to browser_tests. Compared to ui_tests, browser_tests are faster, le…

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/workers/terminate_queued_workers.html

Issue 9802025: Rewrite HTML5 workers ui_tests to browser_tests. Compared to ui_tests, browser_tests are faster, le… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: add directory create call needed on linux Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/chrome_tests.gypi ('K') | « chrome/test/data/workers/queued_shared_worker_shutdown.html ('k') | chrome/test/data/workers/worker_close.html » ('j') | chrome/test/data/workers/worker_utils.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <html>	1 <html>

2 <head>	2 <head>

3 <title>Single Worker Test</title>	3 <title>Single Worker Test</title>

4	4

5 <script src="worker_utils.js"></script>	5 <script src="worker_utils.js"></script>

6	6

7 <script>	7 <script>

8 var workers = [];	8 var workers = [];

9 function startAndTerminateWorkers() {	9 function startAndTerminateWorkers() {

10 var terminateCount = 0;	10 var terminateCount = 0;

11 for (var i = 0 ; i < 200 ; i++) {	11 for (var i = 0 ; i < 16 ; i++) {

12 var w = new Worker("worker_common.js");	12 var w = new Worker("worker_common.js");

13 workers.push(w);	13 workers.push(w);

14 w.postMessage("ping");	14 w.postMessage("ping");

15 w.onmessage = function() {	15 w.onmessage = function() {

16 terminateCount++;	16 terminateCount++;

17 if (terminateCount == 16) {	17 if (terminateCount == 16) {

18 shutdownWorkers();	18 shutdownWorkers();

19 }	19 }

20 if (terminateCount > 16) {

21 // Should not get more than 16 messages back unless we raise the worker

22 // limit.
Andrew T Wilson (Slow) 2012/03/28 22:44:09 Why did we get rid of this check? Was it race-y? Why did we get rid of this check? Was it race-y? jam 2012/03/28 23:01:27 now we can run more than 16 workers with isolates Show quoted text On 2012/03/28 22:44:09, Andrew T Wilson wrote: > Why did we get rid of this check? Was it race-y? now we can run more than 16 workers with isolates Andrew T Wilson (Slow) 2012/03/28 23:49:27 Note that now this test doesn't actually do much u Note that now this test doesn't actually do much useful if we can't cause queued workers. Doesn't hurt to keep it around, but it doesn't actually do what it claims (queue up workers, then terminate them before they can get started). jam 2012/03/29 01:03:41 good point. I tried to switch it to a SharedWorker Show quoted text On 2012/03/28 23:49:27, Andrew T Wilson wrote: > Note that now this test doesn't actually do much useful if we can't cause queued > workers. Doesn't hurt to keep it around, but it doesn't actually do what it > claims (queue up workers, then terminate them before they can get started). good point. I tried to switch it to a SharedWorker but didn't see a way to terminate it. I tried removing a reference to it but then I think this would just be racy on when it dies, so it's not that useful (correct me if I'm wrong). deleted the test
23 onFailure();

24 }

25 }	20 }

26 }	21 }

27 }	22 }

28	23

29 function shutdownWorkers() {	24 function shutdownWorkers() {

30 for (var i = 0 ; i < workers.length ; i++) {	25 for (var i = 0 ; i < workers.length ; i++) {

31 workers[i].terminate();	26 workers[i].terminate();

32 }	27 }

33 workers = [];	28 workers = [];

34 onSuccess();	29 onSuccess();

35 }	30 }

36	31

37 startAndTerminateWorkers();	32 startAndTerminateWorkers();

38 </script>	33 </script>

39	34

40 <body>	35 <body>

41 <div id=statusPanel></div>	36 <div id=statusPanel></div>

42 </body>	37 </body>

OLD	NEW