Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(763)

Issue 9802006: Implement active wheel fling transfer via WebCompositorInputHandlerClient (Closed)

Created:
8 years, 9 months ago by jamesr
Modified:
8 years, 9 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, apatrick_chromium
Visibility:
Public.

Description

Implement active wheel fling transfer via WebCompositorInputHandlerClient There are cases where we'll process a GestureFlingStart event on the compositor thread, initiate a wheel fling, and then later determine that we can't process the rest of the animation on the compositor thread. One example of where this could happen is if the page registers a mousewheel JS event listener while the fling is in progress. In this case, we need to transfer the animation to the WebView to process so it can generate the correct events. This implements the transfer as a call out via the WebCompositorInputHandlerClient. I think this is a reasonable place to put the interface, since it's intimately related with the input processing stream. BUG=don't have handy, but there is one TEST=wheel fling on CrOS should work with --enable-threaded-compositing Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=129487

Patch Set 1 #

Patch Set 2 : use WeakPtr to avoid RenderViewImpl shutdown race on main threa #

Patch Set 3 : cut unnecessary includes #

Total comments: 5

Patch Set 4 : address comments #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -26 lines) Patch
M content/renderer/gpu/compositor_thread.h View 1 2 3 3 chunks +15 lines, -4 lines 0 comments Download
M content/renderer/gpu/compositor_thread.cc View 1 2 3 6 chunks +48 lines, -16 lines 1 comment Download
M content/renderer/render_view_impl.h View 1 2 3 3 chunks +5 lines, -0 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 2 3 2 chunks +16 lines, -0 lines 0 comments Download
M content/renderer/render_widget.cc View 1 2 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
nduca
Hey James, since I can't add to this patch [grrrr reitveld], I've taken on this ...
8 years, 9 months ago (2012-03-21 07:42:31 UTC) #1
jamesr
This depends on https://bugs.webkit.org/show_bug.cgi?id=81740 for WebKit API
8 years, 9 months ago (2012-03-26 22:55:43 UTC) #2
nduca
I see what you did there. ;) LGTM
8 years, 9 months ago (2012-03-27 00:13:07 UTC) #3
darin (slow to review)
http://codereview.chromium.org/9802006/diff/7001/content/renderer/gpu/compositor_thread.cc File content/renderer/gpu/compositor_thread.cc (right): http://codereview.chromium.org/9802006/diff/7001/content/renderer/gpu/compositor_thread.cc#newcode69 content/renderer/gpu/compositor_thread.cc:69: void TransferActiveWheelFlingAnimation( Another approach would be to define this ...
8 years, 9 months ago (2012-03-27 03:47:54 UTC) #4
jamesr
On 2012/03/27 03:47:54, darin wrote: > http://codereview.chromium.org/9802006/diff/7001/content/renderer/gpu/compositor_thread.cc > File content/renderer/gpu/compositor_thread.cc (right): > > http://codereview.chromium.org/9802006/diff/7001/content/renderer/gpu/compositor_thread.cc#newcode69 > ...
8 years, 9 months ago (2012-03-27 03:55:49 UTC) #5
darin (slow to review)
On Mon, Mar 26, 2012 at 8:55 PM, <jamesr@chromium.org> wrote: > On 2012/03/27 03:47:54, darin ...
8 years, 9 months ago (2012-03-27 06:18:23 UTC) #6
jamesr
http://codereview.chromium.org/9802006/diff/10002/content/renderer/gpu/compositor_thread.cc File content/renderer/gpu/compositor_thread.cc (right): http://codereview.chromium.org/9802006/diff/10002/content/renderer/gpu/compositor_thread.cc#newcode109 content/renderer/gpu/compositor_thread.cc:109: render_view_impl)); Since you asked for const ref on the ...
8 years, 9 months ago (2012-03-27 17:38:57 UTC) #7
darin (slow to review)
On Tue, Mar 27, 2012 at 10:38 AM, <jamesr@chromium.org> wrote: > > http://codereview.chromium.**org/9802006/diff/10002/** > content/renderer/gpu/**compositor_thread.cc<http://codereview.chromium.org/9802006/diff/10002/content/renderer/gpu/compositor_thread.cc> ...
8 years, 9 months ago (2012-03-27 23:24:50 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/9802006/10002
8 years, 9 months ago (2012-03-28 18:32:42 UTC) #9
commit-bot: I haz the power
8 years, 9 months ago (2012-03-28 21:10:26 UTC) #10
Change committed as 129487

Powered by Google App Engine
This is Rietveld 408576698