[WebUI] Fix multiple rule regex.

[WebUI] Fix multiple rule regex.

R=tbreisacher@chromium.org,estade@chromium.org
BUG=113202
TEST=:not(blah):not(blee):first-of-type doesn't look like multiple rules
NOTRY=true

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=128164

[Tyler Breisacher (Chromium), 2012-03-21 20:30:03]

http://codereview.chromium.org/9802002/diff/1/chrome/browser/resources/web_de...
File chrome/browser/resources/web_dev_style/css_checker.py (right):

http://codereview.chromium.org/9802002/diff/1/chrome/browser/resources/web_de...
chrome/browser/resources/web_dev_style/css_checker.py:85: return
re.search('[_a-zA-Z0-9-]:(?!\/\/)[^;]+;\s*[^ }]\s*', line)
You don't have to escape the slashes. So (?!\/\/) can be just (?!//). Same at
line 68. I'm also not totally following what you're doing here. AFAIK CSS only
allows /* this type */ of comments, not '// this type' so why are we checking
for '//' anyway?

[Dan Beam, 2012-03-21 20:47:28]

http://codereview.chromium.org/9802002/diff/1/chrome/browser/resources/web_de...
File chrome/browser/resources/web_dev_style/css_checker.py (right):

http://codereview.chromium.org/9802002/diff/1/chrome/browser/resources/web_de...
chrome/browser/resources/web_dev_style/css_checker.py:85: return
re.search('[_a-zA-Z0-9-]:(?!\/\/)[^;]+;\s*[^ }]\s*', line)
On 2012/03/21 20:30:03, Tyler Breisacher wrote:
> You don't have to escape the slashes. So (?!\/\/) can be just (?!//). Same at
> line 68. I'm also not totally following what you're doing here. AFAIK CSS only
> allows /* this type */ of comments, not '// this type' so why are we checking
> for '//' anyway?

this is ignoring the : in protocols as in:
  background-image: url(chrome://resources/BLAH);
                              ^ had issues with this

[Tyler Breisacher (Chromium), 2012-03-21 20:58:39]

Cool, thanks for the explanation. lgtm

[Evan Stade, 2012-03-22 02:43:48]

same as other code review, I'm not comfortable in python, you should get someone
better to review that aspect. otherwise lgtm

[Dirk Pranke, 2012-03-22 03:28:45]

lgtm otherwise; kind of a rubber-stamp on the details of the regexes.

http://codereview.chromium.org/9802002/diff/5001/chrome/browser/resources/web...
File chrome/browser/resources/web_dev_style/css_checker.py (right):

http://codereview.chromium.org/9802002/diff/5001/chrome/browser/resources/web...
chrome/browser/resources/web_dev_style/css_checker.py:85: return
re.search('[_a-zA-Z0-9-]:(?!//)[^;]+;\s*[^ }]\s*', line)
nit: I'd probably make this a raw string for consistency even though it's not
really needed.

[Dan Beam, 2012-03-22 03:29:36]

http://codereview.chromium.org/9802002/diff/5001/chrome/browser/resources/web...
File chrome/browser/resources/web_dev_style/css_checker.py (right):

http://codereview.chromium.org/9802002/diff/5001/chrome/browser/resources/web...
chrome/browser/resources/web_dev_style/css_checker.py:85: return
re.search('[_a-zA-Z0-9-]:(?!//)[^;]+;\s*[^ }]\s*', line)
On 2012/03/22 03:28:45, Dirk Pranke wrote:
> nit: I'd probably make this a raw string for consistency even though it's not
> really needed. 

Done.

[commit-bot: I haz the power, 2012-03-22 03:41:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dbeam@chromium.org/9802002/10004

[commit-bot: I haz the power, 2012-03-22 03:41:47]

Change committed as 128164