Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5728)

Unified Diff: chrome/browser/resources/test_presubmit.py

Issue 9802002: [WebUI] Fix multiple rule regex. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/web_dev_style/css_checker.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/test_presubmit.py
diff --git a/chrome/browser/resources/test_presubmit.py b/chrome/browser/resources/test_presubmit.py
index ed49978c521f7c47d89a4180a9b8c9ec4af0df8f..2886a9b93585ceac8dbeb4dd31eaa652b11036cc 100755
--- a/chrome/browser/resources/test_presubmit.py
+++ b/chrome/browser/resources/test_presubmit.py
@@ -292,7 +292,7 @@ blah /* hey! */
def testCssCloseBraceOnNewLine(self):
self.VerifyContentsProducesOutput("""
-@media { /* TODO(dbeam) Fix this case.
+@media { /* TODO(dbeam) Fix this case. */
.rule {
display: block;
}}
@@ -304,7 +304,11 @@ blah /* hey! */
def testCssColonsHaveSpaceAfter(self):
self.VerifyContentsProducesOutput("""
-div:not(.class):not([attr]) /* We should not catch this. */ {
+div:not(.class):not([attr=5]), /* We should not catch this. */
+div:not(.class):not([attr]) /* Nor this. */ {
+ background: -webkit-linear-gradient(left, red,
+ 80% blah blee blar);
+ color: red;
display:block;
}""", """
- Colons (:) should have a space after them.
@@ -351,7 +355,11 @@ html[dir=ltr] body /* TODO(dbeam): Require '' around rtl in future? */ {
def testCssOneRulePerLine(self):
self.VerifyContentsProducesOutput("""
+a:not([hidden]):not(.custom-appearance):not([version=1]):first-of-type,
+a:not([hidden]):not(.custom-appearance):not([version=1]):first-of-type ~
+ input[type='checkbox']:not([hidden]),
div {
+ background: url(chrome://resources/BLAH);
rule: value; /* rule: value; */
rule: value; rule: value;
}""", """
« no previous file with comments | « no previous file | chrome/browser/resources/web_dev_style/css_checker.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698