Issue 9773026: Add a method on native classes for is checks. Reduces the code for generating is checks.

Issue 9773026: Add a method on native classes for is checks. Reduces the code for generating is checks. (Closed)

Created:
8 years, 9 months ago by ngeoffray

Modified:
8 years, 9 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org, ahe, Lasse Reichstein Nielsen, karlklose, kasperl

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Add a method on native classes for is checks. Reduces the code for generating is checks. Committed: https://code.google.com/p/dart/source/detail?r=5870

Patch Set 6 : #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+102 lines, -119 lines)			Patch
M	frog/leg/emitter.dart	View	1 2 3 4	3 chunks	+15 lines, -6 lines	0 comments	Download
M	frog/leg/lib/native_helper.dart	View	1 2 3	1 chunk	+0 lines, -18 lines	0 comments	Download
M	frog/leg/native_emitter.dart	View	1 2 3 4	3 chunks	+41 lines, -30 lines	0 comments	Download
M	frog/leg/native_handler.dart	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	frog/leg/ssa/codegen.dart	View	1	3 chunks	+45 lines, -64 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

floitsch

LGTM. https://chromiumcodereview.appspot.com/9773026/diff/8/frog/leg/native_emitter.dart File frog/leg/native_emitter.dart (right): https://chromiumcodereview.appspot.com/9773026/diff/8/frog/leg/native_emitter.dart#newcode298 frog/leg/native_emitter.dart:298: // We need to put the super class ...

8 years, 9 months ago (2012-03-26 20:32:59 UTC) #2

ngeoffray

Thanks Florian https://chromiumcodereview.appspot.com/9773026/diff/8/frog/leg/native_emitter.dart File frog/leg/native_emitter.dart (right): https://chromiumcodereview.appspot.com/9773026/diff/8/frog/leg/native_emitter.dart#newcode298 frog/leg/native_emitter.dart:298: // We need to put the super ...

8 years, 9 months ago (2012-03-27 10:48:53 UTC) #3

floitsch

https://chromiumcodereview.appspot.com/9773026/diff/8/frog/leg/ssa/codegen.dart File frog/leg/ssa/codegen.dart (right): https://chromiumcodereview.appspot.com/9773026/diff/8/frog/leg/ssa/codegen.dart#newcode1141 frog/leg/ssa/codegen.dart:1141: && Elements.isListSupertype(element, compiler)); On 2012/03/27 10:48:53, ngeoffray wrote: > ...

8 years, 9 months ago (2012-03-28 21:19:01 UTC) #4

ngeoffray

8 years, 9 months ago (2012-03-29 08:27:15 UTC) #5

https://chromiumcodereview.appspot.com/9773026/diff/8/frog/leg/ssa/codegen.dart
File frog/leg/ssa/codegen.dart (right):

https://chromiumcodereview.appspot.com/9773026/diff/8/frog/leg/ssa/codegen.da...
frog/leg/ssa/codegen.dart:1141: && Elements.isListSupertype(element, compiler));
On 2012/03/28 21:19:01, floitsch wrote:
> On 2012/03/27 10:48:53, ngeoffray wrote:
> > On 2012/03/26 20:32:59, floitsch wrote:
> > > I don't understand this assert.
> > 
> > It's to make sure List and String don't share supertypes, otherwise we would
> > need to check more. Added a comment.
> 
> You also added a "!" ;)

Busted :)

Expand Messages | Collapse Messages