Make ExtensionPrefValueMap a ProfileKeyedService.

Make ExtensionPrefValueMap a ProfileKeyedService.

BUG=104095
TEST=no


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=131136

[Yoyo Zhou, 2012-03-21 00:32:55]

While I'm waiting for ExtensionSystem to get unblocked, I thought I'd fix up
this one in the meantime.

[Elliot Glaysher, 2012-03-21 00:37:48]

the patch lg, but I assume you shouldn't commit this until after the main
ExtensionSystem patch has gone in (because this changes the destruction order so
ExtensionPrefValueMap is destroyed before ExtensionSystem otherwise).

http://codereview.chromium.org/9764006/diff/13/chrome/browser/extensions/exte...
File chrome/browser/extensions/extension_pref_value_map.cc (right):

http://codereview.chromium.org/9764006/diff/13/chrome/browser/extensions/exte...
chrome/browser/extensions/extension_pref_value_map.cc:30: if (!destroyed_) {
I assume this is here because ExtensionPrefValueMap is instantiated directly in
test code?

[Yoyo Zhou, 2012-03-21 22:46:23]

On 2012/03/21 00:37:48, Elliot Glaysher wrote:
> the patch lg, but I assume you shouldn't commit this until after the main
> ExtensionSystem patch has gone in (because this changes the destruction order
so
> ExtensionPrefValueMap is destroyed before ExtensionSystem otherwise).

I suspect this is the source of some of the mysterious test failures. Yes, I'll
have to wait before committing this.

> 
>
http://codereview.chromium.org/9764006/diff/13/chrome/browser/extensions/exte...
> File chrome/browser/extensions/extension_pref_value_map.cc (right):
> 
>
http://codereview.chromium.org/9764006/diff/13/chrome/browser/extensions/exte...
> chrome/browser/extensions/extension_pref_value_map.cc:30: if (!destroyed_) {
> I assume this is here because ExtensionPrefValueMap is instantiated directly
in
> test code?

Yes, that's exactly why.

[Yoyo Zhou, 2012-04-05 08:08:59]

ExtensionSystem looks like it's sticking this time, so I've rebased on top of it
and fixed the test failures. Another look?

[Elliot Glaysher, 2012-04-05 18:00:11]

lgtm

[commit-bot: I haz the power, 2012-04-05 19:24:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yoz@chromium.org/9764006/24001

[commit-bot: I haz the power, 2012-04-05 19:24:13]

Can't apply patch for file chrome/browser/profiles/profile.h.
While running patch -p1 --forward --force;
patching file chrome/browser/profiles/profile.h
Hunk #2 FAILED at 206.
1 out of 2 hunks FAILED -- saving rejects to file
chrome/browser/profiles/profile.h.rej

[commit-bot: I haz the power, 2012-04-05 19:26:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yoz@chromium.org/9764006/32001

[commit-bot: I haz the power, 2012-04-05 19:26:41]

Presubmit check for 9764006-32001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome/browser/protector
    chrome/browser/ui/cocoa

Presubmit checks took 1.9s to calculate.

[Yoyo Zhou, 2012-04-05 19:33:37]

Can you please review this slight refactoring?
ivankr for chrome/browser/protector
rsesek for chrome/browser/ui/cocoa

[Robert Sesek, 2012-04-05 20:17:43]

cocoa/ lgtm

[Ivan Korotkov, 2012-04-06 08:54:38]

protector/ LGTM

[commit-bot: I haz the power, 2012-04-06 12:54:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yoz@chromium.org/9764006/34002

[commit-bot: I haz the power, 2012-04-06 16:26:12]

Change committed as 131136