Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Side by Side Diff: chrome/browser/ui/cocoa/extensions/extension_popup_controller_unittest.mm

Issue 9764006: Make ExtensionPrefValueMap a ProfileKeyedService. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: -- Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/memory/scoped_nsobject.h" 5 #include "base/memory/scoped_nsobject.h"
6 #include "base/memory/scoped_ptr.h" 6 #include "base/memory/scoped_ptr.h"
7 #include "base/message_loop.h" 7 #include "base/message_loop.h"
8 #include "chrome/browser/extensions/extension_pref_value_map.h" 8 #include "chrome/browser/extensions/extension_pref_value_map.h"
9 #include "chrome/browser/extensions/extension_pref_value_map_factory.h"
9 #include "chrome/browser/extensions/extension_prefs.h" 10 #include "chrome/browser/extensions/extension_prefs.h"
10 #include "chrome/browser/extensions/extension_process_manager.h" 11 #include "chrome/browser/extensions/extension_process_manager.h"
11 #include "chrome/browser/extensions/extension_service.h" 12 #include "chrome/browser/extensions/extension_service.h"
12 #include "chrome/browser/ui/browser.h" 13 #include "chrome/browser/ui/browser.h"
13 #include "chrome/browser/ui/cocoa/cocoa_test_helper.h" 14 #include "chrome/browser/ui/cocoa/cocoa_test_helper.h"
14 #include "chrome/browser/ui/cocoa/extensions/extension_popup_controller.h" 15 #include "chrome/browser/ui/cocoa/extensions/extension_popup_controller.h"
15 #include "chrome/test/base/testing_profile.h" 16 #include "chrome/test/base/testing_profile.h"
16 17
17 namespace { 18 namespace {
18 19
19 class ExtensionTestingProfile : public TestingProfile { 20 class ExtensionTestingProfile : public TestingProfile {
20 public: 21 public:
21 ExtensionTestingProfile() {} 22 ExtensionTestingProfile() {}
22 23
23 FilePath GetExtensionsInstallDir() { 24 FilePath GetExtensionsInstallDir() {
24 return GetPath().AppendASCII(ExtensionService::kInstallDirectoryName); 25 return GetPath().AppendASCII(ExtensionService::kInstallDirectoryName);
25 } 26 }
26 27
27 void InitExtensionProfile() { 28 void InitExtensionProfile() {
28 DCHECK(!GetExtensionProcessManager()); 29 DCHECK(!GetExtensionProcessManager());
29 DCHECK(!GetExtensionService()); 30 DCHECK(!GetExtensionService());
30 31
31 manager_.reset(ExtensionProcessManager::Create(this)); 32 manager_.reset(ExtensionProcessManager::Create(this));
32 extension_pref_value_map_.reset(new ExtensionPrefValueMap); 33 extension_prefs_.reset(new ExtensionPrefs(
33 extension_prefs_.reset(new ExtensionPrefs(GetPrefs(), 34 GetPrefs(),
34 GetExtensionsInstallDir(), 35 GetExtensionsInstallDir(),
35 extension_pref_value_map_.get())); 36 ExtensionPrefValueMapFactory::GetForProfile(this)));
36 extension_prefs_->Init(false); 37 extension_prefs_->Init(false);
37 service_.reset(new ExtensionService(this, 38 service_.reset(new ExtensionService(this,
38 CommandLine::ForCurrentProcess(), 39 CommandLine::ForCurrentProcess(),
39 GetExtensionsInstallDir(), 40 GetExtensionsInstallDir(),
40 extension_prefs_.get(), 41 extension_prefs_.get(),
41 false, 42 false,
42 true)); 43 true));
43 service_->set_extensions_enabled(true); 44 service_->set_extensions_enabled(true);
44 service_->set_show_extensions_prompts(false); 45 service_->set_show_extensions_prompts(false);
45 service_->ClearProvidersForTesting(); 46 service_->ClearProvidersForTesting();
(...skipping 11 matching lines...) Expand all
57 } 58 }
58 59
59 virtual ExtensionService* GetExtensionService() { 60 virtual ExtensionService* GetExtensionService() {
60 return service_.get(); 61 return service_.get();
61 } 62 }
62 63
63 private: 64 private:
64 scoped_ptr<ExtensionProcessManager> manager_; 65 scoped_ptr<ExtensionProcessManager> manager_;
65 scoped_ptr<ExtensionPrefs> extension_prefs_; 66 scoped_ptr<ExtensionPrefs> extension_prefs_;
66 scoped_ptr<ExtensionService> service_; 67 scoped_ptr<ExtensionService> service_;
67 scoped_ptr<ExtensionPrefValueMap> extension_pref_value_map_;
68 68
69 DISALLOW_COPY_AND_ASSIGN(ExtensionTestingProfile); 69 DISALLOW_COPY_AND_ASSIGN(ExtensionTestingProfile);
70 }; 70 };
71 71
72 class ExtensionPopupControllerTest : public CocoaTest { 72 class ExtensionPopupControllerTest : public CocoaTest {
73 public: 73 public:
74 virtual void SetUp() { 74 virtual void SetUp() {
75 CocoaTest::SetUp(); 75 CocoaTest::SetUp();
76 profile_.reset(new ExtensionTestingProfile()); 76 profile_.reset(new ExtensionTestingProfile());
77 profile_->InitExtensionProfile(); 77 profile_->InitExtensionProfile();
(...skipping 16 matching lines...) Expand all
94 }; 94 };
95 95
96 TEST_F(ExtensionPopupControllerTest, DISABLED_Basics) { 96 TEST_F(ExtensionPopupControllerTest, DISABLED_Basics) {
97 // TODO(andybons): Better mechanisms for mocking out the extensions service 97 // TODO(andybons): Better mechanisms for mocking out the extensions service
98 // and extensions for easy testing need to be implemented. 98 // and extensions for easy testing need to be implemented.
99 // http://crbug.com/28316 99 // http://crbug.com/28316
100 EXPECT_TRUE([ExtensionPopupController popup]); 100 EXPECT_TRUE([ExtensionPopupController popup]);
101 } 101 }
102 102
103 } // namespace 103 } // namespace
OLDNEW
« no previous file with comments | « chrome/browser/protector/protected_prefs_watcher_unittest.cc ('k') | chrome/chrome_browser_extensions.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698