Issue 976007: Don't assume that the mime type for documents that mshtml rejects is CF

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 976007: Don't assume that the mime type for documents that mshtml rejects is CF (Closed)

Created:
10 years, 9 months ago by tommi (sloooow) - chröme

Modified:
9 years, 7 months ago

Reviewers:
amit

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Don't assume that the mime type for documents that mshtml rejects is CF(!) TEST=If a web site reports a content type that mshtml cannot render (e.g application/text, application/pdf etc) we didn't have a check for our mime type. BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=42706

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -9 lines)			Patch
	M	chrome_frame/urlmon_bind_status_callback.cc	View	1	2 chunks	+17 lines, -8 lines	1 comment	Download
	M	chrome_frame/urlmon_moniker.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

amit

lgtm http://codereview.chromium.org/976007/diff/4001/5001 File chrome_frame/urlmon_bind_status_callback.cc (right): http://codereview.chromium.org/976007/diff/4001/5001#newcode193 chrome_frame/urlmon_bind_status_callback.cc:193: ::GetClipboardFormatNameW(format_etc->cfFormat, format_name, nit: would it be better to ...

10 years, 9 months ago (2010-03-26 00:13:23 UTC) #2

tommi (sloooow) - chröme

10 years, 9 months ago (2010-03-26 00:28:08 UTC) #3

On Thu, Mar 25, 2010 at 5:13 PM, <amit@chromium.org> wrote:

> lgtm
>
>
> http://codereview.chromium.org/976007/diff/4001/5001
> File chrome_frame/urlmon_bind_status_callback.cc (right):
>
> http://codereview.chromium.org/976007/diff/4001/5001#newcode193
> chrome_frame/urlmon_bind_status_callback.cc:193:
>
> ::GetClipboardFormatNameW(format_etc->cfFormat, format_name,
> nit: would it be better to compare the return value of
> RegisterClipboardFormat?

done.

>
>
> http://codereview.chromium.org/976007
>

Expand Messages | Collapse Messages