Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issue 975007: Add fuzz testing driver programs for kernel and firmware verification. (Closed)

Created:
10 years, 9 months ago by gauravsh
Modified:
9 years, 6 months ago
Reviewers:
Chris Masone, sosa
CC:
chromium-os-reviews_chromium.org
Visibility:
Public.

Description

Add fuzz testing driver programs for kernel and firmware verification. The driver programs are useful in quick and dirty fuzz testing of the verification code with blind smartfuzzers like Bunny (http://code.google.com/p/bunny-the-fuzzer/). Also fixes a bug with image generation in kernel_utility. Tests: All existing tests still pass. VerifyKernel() and VerifyFirmware() can successfully verify images generated by {firmware|kernel}_utility.

Patch Set 1 #

Patch Set 2 : Forgot to add the fuzz test image gen script. #

Patch Set 3 : Remove fuzz_testcaases directory. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+202 lines, -9 lines) Patch
M src/platform/vboot_reference/tests/Makefile View 3 chunks +11 lines, -3 lines 0 comments Download
A src/platform/vboot_reference/tests/gen_fuzz_test_cases.sh View 1 chunk +67 lines, -0 lines 2 comments Download
A src/platform/vboot_reference/tests/verify_firmware_fuzz_driver.c View 1 chunk +57 lines, -0 lines 0 comments Download
A src/platform/vboot_reference/tests/verify_kernel_fuzz_driver.c View 1 chunk +56 lines, -0 lines 0 comments Download
M src/platform/vboot_reference/utils/kernel_image.c View 1 chunk +1 line, -0 lines 0 comments Download
M src/platform/vboot_reference/utils/kernel_utility.cc View 5 chunks +10 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
gauravsh
10 years, 9 months ago (2010-03-17 23:18:21 UTC) #1
gauravsh
Not sure if cmasone is still on "vacation", so adding sosa.
10 years, 9 months ago (2010-03-17 23:33:24 UTC) #2
gauravsh
10 years, 9 months ago (2010-03-18 03:21:08 UTC) #3
Chris Masone
LGTM with nit http://codereview.chromium.org/975007/diff/7001/8002 File src/platform/vboot_reference/tests/gen_fuzz_test_cases.sh (right): http://codereview.chromium.org/975007/diff/7001/8002#newcode52 src/platform/vboot_reference/tests/gen_fuzz_test_cases.sh:52: dd if=/dev/urandom of=${TESTCASE_DIR}/${TEST_FILE} bs=${TEST_FILE_SIZE} count=1 80 ...
10 years, 9 months ago (2010-03-18 03:34:05 UTC) #4
sosa
same here http://codereview.chromium.org/975007/diff/7001/8002 File src/platform/vboot_reference/tests/gen_fuzz_test_cases.sh (right): http://codereview.chromium.org/975007/diff/7001/8002#newcode55 src/platform/vboot_reference/tests/gen_fuzz_test_cases.sh:55: if [ ! -d "$TESTKEY_DIR" ] Inconsistent ...
10 years, 9 months ago (2010-03-18 03:37:48 UTC) #5
gauravsh
10 years, 9 months ago (2010-03-18 03:41:14 UTC) #6
On Wed, Mar 17, 2010 at 8:37 PM,  <sosa@chromium.org> wrote:
> same here
>
>
> http://codereview.chromium.org/975007/diff/7001/8002
> File src/platform/vboot_reference/tests/gen_fuzz_test_cases.sh (right):
>
> http://codereview.chromium.org/975007/diff/7001/8002#newcode55
> src/platform/vboot_reference/tests/gen_fuzz_test_cases.sh:55: if [ ! -d
> "$TESTKEY_DIR" ]
> Inconsistent use of {} vs non {} in script

Fixed and submitted.

>
> http://codereview.chromium.org/975007
>



-- 
-g

Powered by Google App Engine
This is Rietveld 408576698