Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9748016: [protector] Added UI for invalid Preferences backup case. (Closed)

Created:
8 years, 9 months ago by Ivan Korotkov
Modified:
8 years, 9 months ago
Reviewers:
dennis_jeffrey, whywhat, sky
CC:
chromium-reviews, dennis_jeffrey, anantha, dyu1, Nirnimesh
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

[protector] Added UI for invalid Preferences backup case. *) Added another BaseSettingChange to represent invalid backup case. *) Few other corrections and strings cleanup. BUG=114288 TEST=protector.py Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=128200

Patch Set 1 #

Patch Set 2 : Merge #

Total comments: 4

Patch Set 3 : Whitespace. #

Total comments: 3

Patch Set 4 : Default settings are applied by Init. #

Patch Set 5 : Merge #

Patch Set 6 : Fix unit-test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+284 lines, -20 lines) Patch
M chrome/app/generated_resources.grd View 2 chunks +10 lines, -3 lines 0 comments Download
M chrome/browser/prefs/session_startup_pref.h View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/prefs/session_startup_pref.cc View 1 2 3 2 chunks +10 lines, -5 lines 0 comments Download
M chrome/browser/protector/base_setting_change.h View 1 chunk +4 lines, -0 lines 0 comments Download
A chrome/browser/protector/prefs_backup_invalid_change.cc View 1 2 3 1 chunk +130 lines, -0 lines 0 comments Download
A chrome/browser/protector/prefs_backup_invalid_change_unittest.cc View 1 2 3 1 chunk +59 lines, -0 lines 0 comments Download
M chrome/browser/protector/protected_prefs_watcher.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/protector/protected_prefs_watcher.cc View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/protector/protected_prefs_watcher_unittest.cc View 1 2 3 4 5 4 chunks +2 lines, -7 lines 0 comments Download
M chrome/browser/protector/session_startup_change.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser_init.h View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/browser_init.cc View 1 2 3 3 chunks +13 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/functional/protector.py View 1 2 3 4 2 chunks +41 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Ivan Korotkov
PTAL whywhat: protector sky: browser/ui dennis: pyauto
8 years, 9 months ago (2012-03-20 15:55:52 UTC) #1
whywhat
lgtm http://codereview.chromium.org/9748016/diff/2001/chrome/browser/protector/prefs_backup_invalid_change.cc File chrome/browser/protector/prefs_backup_invalid_change.cc (right): http://codereview.chromium.org/9748016/diff/2001/chrome/browser/protector/prefs_backup_invalid_change.cc#newcode64 chrome/browser/protector/prefs_backup_invalid_change.cc:64: // TODO(ivankr): highlight the protected prefs on the ...
8 years, 9 months ago (2012-03-20 16:06:00 UTC) #2
dennis_jeffrey
Changes to chrome/test/functional/protector.py LGTM
8 years, 9 months ago (2012-03-20 16:09:08 UTC) #3
Ivan Korotkov
http://codereview.chromium.org/9748016/diff/2001/chrome/browser/protector/prefs_backup_invalid_change.cc File chrome/browser/protector/prefs_backup_invalid_change.cc (right): http://codereview.chromium.org/9748016/diff/2001/chrome/browser/protector/prefs_backup_invalid_change.cc#newcode64 chrome/browser/protector/prefs_backup_invalid_change.cc:64: // TODO(ivankr): highlight the protected prefs on the settings ...
8 years, 9 months ago (2012-03-20 16:16:02 UTC) #4
sky
http://codereview.chromium.org/9748016/diff/6002/chrome/browser/ui/browser_init.cc File chrome/browser/ui/browser_init.cc (right): http://codereview.chromium.org/9748016/diff/6002/chrome/browser/ui/browser_init.cc#newcode951 chrome/browser/ui/browser_init.cc:951: CheckPreferencesBackup(profile); Don't we only want to do this once ...
8 years, 9 months ago (2012-03-20 17:23:18 UTC) #5
Ivan Korotkov
http://codereview.chromium.org/9748016/diff/6002/chrome/browser/ui/browser_init.cc File chrome/browser/ui/browser_init.cc (right): http://codereview.chromium.org/9748016/diff/6002/chrome/browser/ui/browser_init.cc#newcode951 chrome/browser/ui/browser_init.cc:951: CheckPreferencesBackup(profile); On 2012/03/20 17:23:18, sky wrote: > Don't we ...
8 years, 9 months ago (2012-03-20 17:40:59 UTC) #6
Ivan Korotkov
http://codereview.chromium.org/9748016/diff/6002/chrome/browser/ui/browser_init.cc File chrome/browser/ui/browser_init.cc (right): http://codereview.chromium.org/9748016/diff/6002/chrome/browser/ui/browser_init.cc#newcode951 chrome/browser/ui/browser_init.cc:951: CheckPreferencesBackup(profile); On 2012/03/20 17:23:18, sky wrote: > Don't we ...
8 years, 9 months ago (2012-03-21 10:02:06 UTC) #7
sky
LGTM
8 years, 9 months ago (2012-03-21 14:51:12 UTC) #8
Ivan Korotkov
Merge previous CLs. PrefsBackupInvalidChange now applies some default settings initially. Anton, could you take another ...
8 years, 9 months ago (2012-03-21 20:48:36 UTC) #9
whywhat
lgtm Looks good.
8 years, 9 months ago (2012-03-21 21:01:25 UTC) #10
whywhat
lgtm lgtm
8 years, 9 months ago (2012-03-21 21:01:29 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ivankr@chromium.org/9748016/24001
8 years, 9 months ago (2012-03-22 11:36:12 UTC) #12
commit-bot: I haz the power
8 years, 9 months ago (2012-03-22 13:08:27 UTC) #13 
Change committed as 128200

Powered by Google App Engine
This is Rietveld 408576698