chrome/browser/protector/protected_prefs_watcher.cc - Issue 9748016: [protector] Added UI for invalid Preferences backup case.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/protector/protected_prefs_watcher.cc

Issue 9748016: [protector] Added UI for invalid Preferences backup case. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Fix unit-test. Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/protector/protected_prefs_watcher.cc

diff --git a/chrome/browser/protector/protected_prefs_watcher.cc b/chrome/browser/protector/protected_prefs_watcher.cc

index 218a33096d132fe53e3840940fb7fdaf737f58a7..8fedbe063c178899c2d1a449aea68e1f20958cdb 100644

--- a/chrome/browser/protector/protected_prefs_watcher.cc

+++ b/chrome/browser/protector/protected_prefs_watcher.cc

@@ -232,8 +232,9 @@ void ProtectedPrefsWatcher::ValidateBackup() {

kProtectorErrorCount);

} else {

LOG(WARNING) << "Invalid backup signature";

- // Further changes to protected prefs will overwrite the signature.

is_backup_valid_ = false;

+ // The whole backup has been compromised, overwrite it.

+ InitBackup();

UMA_HISTOGRAM_ENUMERATION(

kProtectorHistogramPrefs,

kProtectorErrorBackupInvalid,