Fix crash in AppNotifyChannelSetup when incognito profiles are used.

chrome/browser/extensions/api/app/app_api.cc

Index: chrome/browser/extensions/api/app/app_api.cc
diff --git a/chrome/browser/extensions/api/app/app_api.cc b/chrome/browser/extensions/api/app/app_api.cc
index a03c603df119403b9dc9a9abf7b45a34d890326d..663b59bfd066ab55dc7311f1c70244dd98803714 100644
--- a/chrome/browser/extensions/api/app/app_api.cc
+++ b/chrome/browser/extensions/api/app/app_api.cc
@@ -23,8 +23,16 @@ const char kInvalidExtensionIdError[] =
     "Invalid extension id";
 const char kMissingLinkTextError[] =
     "You must specify linkText if you use linkUrl";
+const char kIncognitoError[] =
+    "This API is not accessible by 'split' mode "
+    "extensions in incognito windows.";
 
 bool AppNotifyFunction::RunImpl() {
+  if (!include_incognito() && profile_->IsOffTheRecord()) {

[Mihai Parparita -not on Chrome, 2012/03/22 19:44:20]

There are actually two app notification APIs:
1) The (experimental) extension API, which allows an extension to display
notifications on behalf of an app (this was added mainly for the sake of
testing/prototyping)
2) The chrome.appNotifications.getChannel, which is what apps actually use. The
incognito check would need to happen in AppBindings::GetAppNotifyChannel and/or
in ExtensionTabHelper::OnGetAppNotifyChannel.

[jstritar, 2012/03/22 20:21:10]

Oh yeah, done. Do you know why this needs such custom bindings?

[asargent_no_longer_on_chrome, 2012/03/22 20:58:11]

Because it's exposed to hosted apps, which the regular extensions bindings
aren't.

[jstritar, 2012/03/23 15:31:43]

Thanks for the explanation! We might be able to get rid of the custom binding
soon then, with the work kalman and aa have been doing.

+    error_ = kIncognitoError;
+    return false;
+  }
+
   DictionaryValue* details;
   EXTENSION_FUNCTION_VALIDATE(args_->GetDictionary(0, &details));
   EXTENSION_FUNCTION_VALIDATE(details != NULL);
@@ -77,6 +85,11 @@ bool AppNotifyFunction::RunImpl() {
 }
 
 bool AppClearAllNotificationsFunction::RunImpl() {
+  if (!include_incognito() && profile_->IsOffTheRecord()) {
+    error_ = kIncognitoError;
+    return false;
+  }
+
   std::string id = extension_id();
   DictionaryValue* details = NULL;
   if (args_->GetDictionary(0, &details) && details->HasKey(kExtensionIdKey)) {